Add exterior displays to Super/Quantum Chests and Tanks - #7856
Open
HFPTetraUro wants to merge 17 commits into
Open
Add exterior displays to Super/Quantum Chests and Tanks#7856HFPTetraUro wants to merge 17 commits into
HFPTetraUro wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UPDATE:
I changed the Super Chest inventory rendering to have the old orange computer display face show, to make it more recognizable. However this is different than the in world rendering - the orange screen in the front, item display is always behind it.
Maybe this is confusing? not sure. And maybe we can change it so the orange screen goes on top like the super tank and the face of the chest will always be the display window.
Adds exterior storage displays to Super/Quantum Chests and Tanks.
Super/Quantum Chests now have a display window on their backside showing the stored item, based on the design from #4209. The item is rendered inside the block with an optional compact item count below it (on by default). This only takes the design from that PR, the implementation does not depend/copy code from it. The window texture is copied unchanged from the PR.
Super/Quantum Tanks now have windows on each uncovered horizontal side except the output side. The stored fluid is rendered behind the windows at its fill level using the fluid's texture. The output side keeps its existing texture, and covered sides keep the current casing texture and cover on top.


An optional amount/capacity display can also be shown on the tank windows, configurable, disabled by default.

Filled tanks render their stored fluid in the inventory, but not when thrown on the ground.


Implementation
This is my first "big" code contribution to GT5U so comments on the style or approach I've took is welcome.
The main "hack"(?) was that tank inventory rendering needed a small wrapper around the existing
ItemMachinesrenderer so it can render from the actual stack data without interfering with the Ice Cream Machine's special renderer.Checklist