Fix MTEBuffer handling of heterogeneous target inventories - #7850
Open
lfpraca wants to merge 2 commits into
Open
Fix MTEBuffer handling of heterogeneous target inventories#7850lfpraca wants to merge 2 commits into
lfpraca wants to merge 2 commits into
Conversation
lfpraca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MTEBuffer implementation used to check if any available slot in the target inventory had enough space for a stack to be pushed.
This created false negatives if the inventory had enough space but not in a single slot, and created false positives if any slot had enough space but there wasn't enough space compatible with the item to be pushed, this false positive made it so that partial stacks could be pushed, breaking automation.
This PR fixes the handling to check the available spaces in all slots where the stack could be pushed, checking if that particular stack is compatible with the available space.
This fixes GTNewHorizons/GT-New-Horizons-Modpack#24629
Checklist