Fix game crash when building a mega distillation tower in creative using hologram - #7849
Open
6C-C6 wants to merge 2 commits into
Open
Fix game crash when building a mega distillation tower in creative using hologram#78496C-C6 wants to merge 2 commits into
6C-C6 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Got a game crash when trying to build a mega distillation tower (new structure one), with
on function
according to the crash report.
Fix it by adding the layer index by 1, and use index-1 for
outputHatchesPerLayer.get().Refrencing to the old structure's code:
GT5-Unofficial/src/main/java/bartworks/common/tileentities/multis/mega/MTEMegaDistillTowerLegacy.java
Line 207 in 6ad722c
Also change the variable name from
currentLayertocurrentOutputLayer, as the previous one has already been used otherwhere in the code, refering to the layer index of middle pieces.Checklist