Repository navigation
Load variables not in the data standard with a warning - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataSetcan now load saved files that contain variables which are not part of the current data standard. Previously this raisedAttributeError: Cannot set attribute '...'. It is not part of the saving strategy, so a file written by a branch with an extended (or older, renamed) standard could not be loaded from another branch. Such variables are now attached to the dataset and a warning is logged.Feature / enhancement
Design notes
DataSet._load_variablechanged. Unknown names are set withobject.__setattr__and alogger.warning.__setattr__is untouched, so user-set typos likeds.typo = 1still raise.Checklist
ruff check/ruff formatclean.test_variable_missing_from_standard_is_loaded_with_warning, markedbasic);tests/unittests/datasetpasses.