Review v3 changes

[matamadio]

Checklist before deploy to production

GFDRR to perform review of changes

as from https://github.com/GFDRR/thinkhazard/milestone/8 and contract tasklist

• Search engine for ADM/Urban
• Fix locations names and labels
• GUI fixes
• Documentation
• Update contacts and climate change recomendations (@stufraser1, @matamadio)
• Translate new text content (@stufraser1, @matamadio)
• External review of updated hazard scores: see ThinkHazard! v3.0 scores review #1041
  • Propose list of reviewers and invite them to a kickoff call
• Check API functionality (depends on deploy on prod server)

C2C to ensure that GFDRR team is able to:

• access adm panel and push changes to prod server
  • dataset
  • text content
  • transifex
• perform websites updates to prod server (news ticker, logos, hazard descriptions and similar)
  • GH workflow for auto-deploy changes
  • Along the duration of hosting service, C2C will provide basic maintanance by review and merge PRs for required small changes
• access and edit TH DB for batch content update
  • C2C to provide step-by-step instructions for safe update

C2C to solve/archive long pending issues, PRs (6) and branches (33):

• Dependencies updates
• Custom deployments of TH (Build error #938)
• Oldest and stale branches. It would be good to also clean any unused file and function from current branch, after confirming that backup of previous version remains in branch 2.1.

[pzwsk]

Hierarchy issue with Urban Area

Issue: Many Urban Areas entities still appear to be within the wrong administrative division.

Solution: Since an urban area entity may overlap with ADM2 or even ADM1 I suggest to put the Urban Area just after the Country name in the breadcrumb. This will avoid the risk of showing wrong information.

Examples :

Kinshasa Urban Area should appear to be part of Kinshasa Province or DRC.

Paris should appear to be part of Ile de France or France.

[pzwsk]

Issues with search results

France

Searching for France results in two urban with France so OK but also five "France" linking to the actual continental country but also the different DOM-TOMs

Congo

Returns 5 locations with Congo including Republic of Congo but not the Democratic Republic of Congo

Roseau

Does not return Roseau the capital of Dominica. Same is true for Castries, the capital of Saint Lucia. Might the case for most of small states island in the caribbean.

[pzwsk]

Search results

I suggest the following changes to the search results.

• No division between ADM and Urban but instead we prioritize countries and capitals whatever their ADM level
• We list countries first, then capitals, then Urban GHSL Center, then other results
• We distinguish clearly between country, capital and GHSL Urban Center
• We use the term GHSL Urban Center as it is the one used by GHSL itself and will speak to expert users and Urban is confusing for normal users
• No max results or more than 5 (looks like we are limiting to 5 for now)

Here are examples:

[matamadio]

Hierarchy issue with Urban Area

Issue: Many Urban Areas entities still appear to be within the wrong administrative division.

Solution: Since an urban area entity may overlap with ADM2 or even ADM1 I suggest to put the Urban Area just after the Country name in the breadcrumb. This will avoid the risk of showing wrong information.

Has to be done indeed, as already discussed. Apologies I missed to track it.

Issues with search results

France

Searching for France results in two urban with France so OK but also five "France" linking to the actual continental country but also the different DOM-TOMs

Should be fixed in the upcoming ADM data update.

Congo

Returns 5 locations with Congo including Republic of Congo but not the Democratic Republic of Congo

Has to be fixed in the search function.

Roseau

Does not return Roseau the capital of Dominica. Same is true for Castries, the capital of Saint Lucia. Might the case for most of small states island in the caribbean.

Unfortunately those are too small to be part of the Copernicus urban areas dataset. If we want them to be included, we need to gather them from different sources.

[matamadio]

• C2C (@arnaud-morvan, @ronitjadhav) to remove separator between ADM and URB results, adding the label on the side (Country, Capital, Adm division, GHSL urban area) and reflect this order in search results sorting
• @matamadio to add field "Capital" to urban areas (Yes/No)

[matamadio]

Just pushed update and pushed to int.thinkhazard.org:

• Fixed ADM boundaries for
  • Names / Duplications
  • Duplicated codes
  • Capitals: adding a few missing ones available from GHSL, added "CAPITAL" boolean.
• Added flood scores (except russia and fiji)
  • FL_Hazard_score
  • PF_Hazard_score
  • CF_Hazard_score
• Updated text description (first paragraph)

Completed wih no errors in the log.

Issues:

• All floods scores still missing from website

[matamadio]

Remaining issues:

• Remove ADM2 from urban areas search breadcrumb:

• Aggregated scores (ADM1, ADM0) seem to be missing: