feat: mesh for test in mesh-doctor#257
Merged
Merged
Conversation
jafranc
added
flag: ready for review
type: feature
test-geos-integration
bd713
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing and extending small meshes generation functions to build test for mesh-doctor utilities. It introduces:
test_orphan.pytestig regular full 3D, 2D/3D with no orphan and with orphan for count and indexestest_euler.pyregular meshes and non-manifold volume (bow-tie) and surfacic (flap) as well as throw for pure 2D (as expected)adding to already existing test
test_collocatedNodes.pyanother mesh with collocation with check of indexestest_elementVolume.pywith a negative cell above or not the thresholdtest_selfIntersecting.pywith a wrongfully oriented faceTo be discussed if old tests are to be kept or not (as this approach centralize generation).