feat: apply jafranc review comments on PR#251 (euler surface)#256
Merged
Conversation
…hon 3.12+ compatibility On Ubuntu 24.04 with Python 3.12+, the distutils module no longer exists in the standard library. This caused package builds to fail with "ModuleNotFoundError: No module named 'distutils'". The fix is to install setuptools, wheel, and pip upfront before attempting to build and install packages. This ensures the build dependencies are available for all subsequent package installations. Moved build dependency installation to the "Install build dependencies" step that runs before package installation.
* starting import launcher handling * ssh login * full PoC * change host * update versions f/ VFileUpload * start status * job status track * kill jobs enable * working w/o copyback * first attempt at copy back * update regex * alternate strat copy back * discard sim_status_view * spliting up big block * refactor cluster entries * completion bars * adjust install and pathing * sd works for external mesh * with internal mesh too * env and assets loading logique * fine-grained conf * rename transfer partition * fixing imporper eval of num unk * allow .vtk for wells meshes * add list of req files before run * yapf * Update .gitignore to include user-specs note * Update Docker image for integration tests * fix CI test-geos-integration with local env for U24 * few fixes
* PR gen from script by copilot * scrap vtk full import * using writing and reading logic * adding some tests * adding component splitter * fix test w/ cc * yapf * copilot review
- Add SetRegionIdAssignmentMode(CELL_COUNT_DESCENDING) after SetExtractionModeToAllRegions() in __countConnectedComponents so regions are ordered largest-first (suggestion on line 154). - Add comment that GetConnectivityArray/GetOffsetsArray require VTK 9+ (comment on line 233). - Store non-manifold edge point-id pairs in SurfaceComponent and display them (up to 10) in the results output so users know exactly where non-manifold edges are located (question on line 249). https://claude.ai/code/session_01GwpNNFQRPhb26XMCFHJtts
jafranc
added
flag: ready for review
test-geos-integration
bd713
reviewed
May 29, 2026
jafranc
changed the title
bd713
approved these changes
Jun 2, 2026
…V/geosPythonPackages into jafranc/EulerPropDisplay
jafranc
added a commit
that referenced
this pull request
Jun 2, 2026
* draft * feat: apply jafranc review comments on PR#251 (euler surface) (#256) * revert ascending order * adding a toGlobalEdgeId helper --------- Co-authored-by: DENEL Bertrand <bertrand.denel@total.com> Co-authored-by: jacques franc <jacquesfrancdev@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetRegionIdAssignmentMode(CELL_COUNT_DESCENDING) after SetExtractionModeToAllRegions()in__countConnectedComponentsso regions are ordered largest-first (suggestion on line 154).GetConnectivityArray/GetOffsetsArray require VTK 9+(comment on line 233).SurfaceComponentand display them (up to 10) in the results output so users know exactly where non-manifold edges are located (question on line 249).