fix(cli): reject exiting dispatch leaders on macOS - #2501
Merged
limityan merged 1 commit intoAug 25, 2026
Merged
Conversation
wgqqqqq
force-pushed
the
codex/fix-macos-cli-cancellation-test-explore
branch
from
August 25, 2026 12:01
c86bb3d to
de4b85d
Compare
wgqqqqq
force-pushed
the
codex/fix-macos-cli-cancellation-test-explore
branch
from
August 25, 2026 12:55
de4b85d to
1f006de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport only the macOS dispatch fix from #2497 to
1.0.0-explore:psstates carrying the exitingEmodifier before SIGKILL escalationI,R,S,T,U)No telemetry/configuration changes from #2497 are included.
Root cause
The intermittent failure exposed a real exit-window race.
kill(pid, 0)can still observe a leader that is already trying to exit, while macOSpsmarks that state with theEmodifier. The previous zombie-only check accepted values such asSEandUEs, re-authenticated the leader, and allowed SIGKILL escalation after SIGTERM had already initiated exit.Signal ordering and timeout behavior remain unchanged.
Verification
eadedaded