-
Notifications
You must be signed in to change notification settings - Fork 2
test: add Rust Sweettest substrate bridge coverage #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
361a1de
e2cc443
5e49fe0
e248188
734fe31
02e2959
83587b6
1988c66
5900d13
20f5668
c3efa13
2379add
9a9cc94
7ec5e90
77835df
55bcc58
c925ed1
4db3d9a
de9ea44
4618ec0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,21 @@ | ||
| # Cargo configuration for the FLOSSI0ULLK Rose Forest workspace. | ||
| # | ||
| # Added 2026-05-19 alongside the holochain-0.4 -> holochain-0.6 migration. | ||
| # HDI 0.7.1 / HDK 0.6.1 brings in getrandom 0.3.x, which requires explicit | ||
| # opt-in for the wasm32-unknown-unknown target via a config flag (see the | ||
| # getrandom 0.3 release notes and the Holochain HDK 0.6 docs). Without | ||
| # this, building wasm artifacts fails with: | ||
| # HDI 0.7.1 / HDK 0.6.1 brings in getrandom 0.3.x, which requires an explicit | ||
| # wasm32-unknown-unknown backend. Holochain 0.6.1's test-utils guest build | ||
| # contract uses its HDK-provided custom backend, not the browser wasm_js | ||
| # backend. The size optimization matches that upstream guest-build contract. | ||
| # Without an explicit backend, building WASM artifacts fails with: | ||
| # | ||
| # error[E0425]: cannot find function `fill_inner` in module `backends` | ||
| # | ||
| # Cross-reference: | ||
| # - FLOSS/docs/agent-memory/project/holochain-version-line-skew.md | ||
| # - FLOSS/docs/specs/consent-payload.spec.md (validation-status table) | ||
| # - Upstream contract: holochain crates/test_utils/wasm/build.rs:86 sets | ||
| # `-C opt-level=z --cfg getrandom_backend="custom"` for ALL wasm guest | ||
| # builds; the HDK defines __getrandom_v03_custom. This config mirrors | ||
| # that exact guest-build contract so release WASMs are reproducible. | ||
|
|
||
| [target.wasm32-unknown-unknown] | ||
| rustflags = ['--cfg', 'getrandom_backend="wasm_js"'] | ||
| rustflags = ['-C', 'opt-level=z', '--cfg', 'getrandom_backend="custom"'] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -149,7 +149,7 @@ fn validate_thought_credential( | |
| )); | ||
| } | ||
| let dim = credential.content.len(); | ||
| if dim < 32 || dim > 4096 { | ||
| if !(32..=4096).contains(&dim) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Align the changed paths with the approved plan. Step 5 compares Revert both equivalent integrity rewrites, or update the global constraint and expected paths with explicit approval. Add 🤖 Prompt for AI Agents |
||
| return Ok(ValidateCallbackResult::Invalid(format!( | ||
| "E_THOUGHT_CONTENT_DIM: {} out of [32,4096]", | ||
| dim | ||
|
|
@@ -182,7 +182,7 @@ fn validate_rose_node(node: &RoseNode) -> ExternResult<ValidateCallbackResult> { | |
| ))); | ||
| } | ||
| let dim = node.embedding.len(); | ||
| if dim < 32 || dim > 4096 { | ||
| if !(32..=4096).contains(&dim) { | ||
| return Ok(ValidateCallbackResult::Invalid(format!( | ||
| "E_EMBED_DIM: {} out of [32,4096]", | ||
| dim | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.