Qwen3.6 vLLM support: add save_format="full_wrapper" for quantized model save#36
Open
dogwood-flo wants to merge 23 commits into
Open
Qwen3.6 vLLM support: add save_format="full_wrapper" for quantized model save#36dogwood-flo wants to merge 23 commits into
save_format="full_wrapper" for quantized model save#36dogwood-flo wants to merge 23 commits into
Conversation
…se attention type checks
…neCompression into feature/qwen36_27b_save
This reverts commit 1b5bb84.
This reverts commit 64fc908.
This reverts commit 0e006d6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_formatparameter ("auto"/"native"/"full_wrapper", default"auto") toRunner.save_quantized_model()."full_wrapper"remaps a text-only quantized checkpoint (e.g. Qwen3.6) to the compositemodel.language_model.*namespace that vLLM's composite VLM loader expects (onecomp/runner.py)."full_wrapper"is scoped specifically to Qwen3.6 (model_typeinqwen3_5_text/qwen3_5_moe_text) — any other model (including other VLMs) raisesRuntimeError.This pull request should be reviewed after merging (#35).
Background
Qwen3.6 quantizes as a text-only checkpoint, but vLLM's composite
Qwen3_5ForConditionalGenerationloader expects themodel.language_model.*namespace — a mismatch from the plain Hugging Face save layout.Details
Qwen3.6 vLLM support: full-wrapper quantized model save
save_formatparameter ("auto"/"native"/"full_wrapper", default"auto") toRunner.save_quantized_model()."full_wrapper"saves a text-only quantized checkpoint (e.g. Qwen3.6) remapped to the compositemodel.language_model.*state_dict/config namespace that vLLM's full-wrapper VLM loading expects, and additionally savesAutoProcessor/AutoImageProcessorfiles (onecomp/runner.py)Bug fix
SyntaxErrorinonecomp/utils/blockwise.pyand broken save logic inRunner.save_quantized_model()(missingsave_formatparameter, danglingtrywithoutexcept, undefined variable reference), and removed dead duplicate code (onecomp/runner.py)Test
save_format's namespace-detection/remap helpers and its Qwen3.6-only scoping, plus end-to-end checks thatfull_wrapperrestoresmodel.configafter save and that the defaultsave_formatremains a no-op for non-Qwen models (tests/onecomp/runner/test_save_format_full_wrapper.py)Corresponding documents have been modified.
Verified
Verified the implementation with the following script: