Skip to content

Added array return type to _getSidebarNavigation() - #345

Closed
pgunsolley wants to merge 12 commits into
FriendsOfCake:devfrom
pgunsolley:bugfix/sidebar-navigation-trait
Closed

Added array return type to _getSidebarNavigation()#345
pgunsolley wants to merge 12 commits into
FriendsOfCake:devfrom
pgunsolley:bugfix/sidebar-navigation-trait

Conversation

@pgunsolley

Copy link
Copy Markdown

Custom menu configuration can accept an array: https://crud-view.readthedocs.io/en/latest/general-configuration/sidebar-navigation.html

Added array return type for _getSidebarNavigation solves invalid return type error when using config array.

@codecov

codecov Bot commented Sep 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev@21af8d0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Listener/ViewListener.php 0.00% 8 Missing ⚠️
src/View/Helper/CrudViewHelper.php 0.00% 4 Missing ⚠️
src/Listener/Traits/SidebarNavigationTrait.php 0.00% 1 Missing ⚠️
src/View/Widget/DateTimeWidget.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #345   +/-   ##
======================================
  Coverage       ?   26.34%           
  Complexity     ?      323           
======================================
  Files          ?       22           
  Lines          ?     1044           
  Branches       ?        0           
======================================
  Hits           ?      275           
  Misses         ?      769           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pgunsolley
pgunsolley changed the base branch from master to dev September 5, 2025 13:11
@pgunsolley
pgunsolley changed the base branch from dev to master September 5, 2025 13:12
@pgunsolley
pgunsolley changed the base branch from master to dev September 5, 2025 13:12
@pgunsolley pgunsolley closed this Sep 5, 2025
@pgunsolley
pgunsolley deleted the bugfix/sidebar-navigation-trait branch September 6, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants