docs: regenerate HTML examples; skip benchmark tests without benchmarks/; py3.9 aarch64 install note - #427
Merged
Conversation
The committed samples predated the report-only duplicate default, the outlier flag default and the not-assessed quality-debt dimensions (#420): rows now read 205 -> 205, revenue shows outliers -> flag (7 flagged), and the quality_debt total is 0.34 with schema_drift/category_churn unknown. Regenerated with scripts/generate_html_examples.py. The action timeline's duration and the quality-debt run_at timestamp are run-dependent and no renderer option omits them, so those lines change on every regeneration.
The sdist ships tests/ but not benchmarks/. conftest.py only filters module-level imports, so tests that read benchmarks/ inside the test body failed or errored from an unpacked sdist. The bench_streaming fixture now uses pytest.importorskip (as the cleanbench suites do), and the entity resolution smoke test and benchmark-stream CLI test skip when the benchmark file is missing. The CLI test also runs from the repo root, since the command resolves benchmarks/ against the working directory.
…source thinc 8.3.4 and blis 1.2.0 publish no cp39 Linux aarch64 wheel, and spacy 3.8.7 (the py3.9 cap) requires thinc>=8.3.4,<8.4, so no pin avoids the source build. Document it in the install guide and next to the py3.9 caps in pyproject.toml. Dependency pins are unchanged.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs:
docs/examples/*.htmlis regenerated withscripts/generate_html_examples.py, so it matches current default output:outliers → flag (7 flagged)schema_driftandcategory_churnare shown as not assessedThe action-timeline duration and the quality-debt
run_attimestamp come from the run itself, and no renderer option omits them, so those two values differ on every regeneration. Regenerating again on current main changed only those two values.Tests: benchmark tests that read
benchmarks/inside the test body now skip when that directory is absent, as in an unpacked sdist, instead of failing or erroring. In a git checkout they still run.bench_streamingfixture usespytest.importorskip, like the cleanbench suites.test_benchmark_smokeandtest_cli_benchmark_stream_writes_jsonskip when their benchmark file is missing.benchmarks/relative to the working directory.Packaging docs: a note in
docs/installation.md, and next to the py3.9 caps inpyproject.toml, says that on Python 3.9 / Linux aarch64 theprivacyextra compiles thinc and blis from source.thinc>=8.3.4,<8.4, so no pin avoids the source build.Tests
tests/test_streaming_cli.py: skip handling for thebench_modulefixture and thebenchmark-streamCLI test.tests/test_enterprise_entity_resolution_dedupe.py: skip handling fortest_benchmark_smoke.Verification
ruff check .: clean.pytest -m "not online and not large":test_clean_duration_within_baselines[aggressive-letter_recognition], a rows-per-second timing check that failed while other suites shared the machine. Isolated reruns failed on different dataset variants. No library code changes in this PR.benchmarks/): the two test files give 43 passed, 4 skipped, 0 failed. In a git checkout the 4 benchmark tests pass.uv lock --check: passes.Default-output changes
None. This PR regenerates committed example HTML to match current output and changes only tests, docs and a
pyproject.tomlcomment. No library code or dependency pins change.