fix(parsers): report an unknown XML encoding as invalid XML - #397
Merged
Merged
Conversation
ET.parse raises LookupError when the XML declaration names an encoding Python does not know. The GPX and SDMX parsers caught only ValueError and ET.ParseError around that call, so the LookupError escaped instead of producing the existing "invalid GPX/SDMX XML" warning with empty frames. Catch LookupError in the same clause as ET.ParseError. Closes #315
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FreshData benchmark report —
|
| fixture | n_rows | n_cols | p50 s | p95 s | peak MB | repair % | false-repair % | preserve % | trust | monotonic | export % |
|---|
Authored-code reduction (Metric 6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ET.parseraisesLookupErrorwhen the XML declaration names an encoding Python does not recognise (for exampleencoding="bogus"). The GPX and SDMX parsers caught onlyValueErrorandET.ParseErroraround that call, sofd.parse_domain(..., format="gpx"|"sdmx")raised instead of returning the usual result for malformed input.This PR catches
LookupErrorin the same clause asET.ParseError. An unknown encoding now gives the existinginvalid GPX XML: .../invalid SDMX XML: ... (audit only)warning and empty frames, as the SDMX module docstring and docs/parsers.md describe. No other behaviour changes.Tests
tests/parsers/test_gpx.py::test_unknown_xml_encoding_returns_warning_not_exception: a GPX document that declares an unknown encoding returns empty frames and aninvalid GPX XMLwarning, with no exception.tests/parsers/test_sdmx.py::test_unknown_xml_encoding_is_audit_only: the same for SDMX, with aninvalid SDMX XML ... (audit only)warning.Verification
ruff check .: passedmypy src/freshdata: no issuespytest -m "not online and not large": Python 3.12: 5136 passed, 13 skipped; Python 3.9 / pandas 1.5: 5132 passed, 17 skippedCloses #315