Fix DeprecationWarning in _json_value by handling array-like values; … - #29
Merged
Merged
Conversation
…add regression test
Extend the DeprecationWarning fix to plan.py (not just duplicate_defense.py): - Add numpy array and pandas Series handling in plan._json_value before pd.isna() call to avoid ambiguous truth-value check - Guard _is_missing_scalar against array-like inputs (np.ndarray, pd.Series, list, tuple, dict) which would fail on bool(pd.isna(array)) - Fix import order in duplicate_defense.py (ruff I001) - Add regression tests for plan._json_value and _is_missing_scalar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…add regression test
Description
Please include a summary of the changes and the related issue/feature description.
Fixes # (issue number if applicable)
Type of Change
Checklist
mypy) and linter checks (ruff) pass locally