Repository navigation
Ensure that nested objects are deserialized in the order of serialization - #4874
Open
robert-brunel wants to merge 1 commit into
Open
robert-brunel wants to merge 1 commit into
robert-brunel wants to merge 1 commit into
Conversation
robert-brunel
force-pushed
the
apple/robert-brunel/fix-proto-read-order
branch
from
November 10, 2026 18:23
35ca628 to
c1279c5
Compare
…tion This change fixes incorrect `fromProto()` methods that were reading nested objects in a different order than `toProto()` writes them. The incorrect order could lead to internal errors (`VerifyException`) during deserialization. During serialization, a record type is serialized in full only at the point of its first occurrence; later occurrences of the type then just refer to the previous occurrence through a reference id. Reading nested objects out of order can cause such a reference to be reached before the actual definition. The affected types are: * `PickValue` * `RecordQueryScoreForRankPlan` and `ScoreForRank` * `RecordQueryInUnionPlan` * `RecordQueryAggregateIndexPlan` * `UserDefinedMacroFunction` * `MultidimensionalIndexScanComparisons` * `RangeConstraints` * `PromoteValue.ArrayCoercionBiFunction` The `PickValue` case is covered end-to-end by the new `CASE` queries in `skipped-field-number-proto.yamsql`. Fixes #4873.
robert-brunel
force-pushed
the
apple/robert-brunel/fix-proto-read-order
branch
from
November 10, 2026 18:59
c1279c5 to
451d6d5
Compare
robert-brunel
marked this pull request as ready for review
November 10, 2026 19:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes incorrect
fromProto()methods that were reading nested objects in a different order thantoProto()writes them. The incorrect order could lead to internal errors (VerifyException) during deserialization. During serialization, a record type is serialized in full only at the point of its first occurrence; later occurrences of the type then just refer to the previous occurrence through a reference id. Reading nested objects out of order can cause such a reference to be reached before the actual definition.The affected types are:
PickValueRecordQueryScoreForRankPlanandScoreForRankRecordQueryInUnionPlanRecordQueryAggregateIndexPlanUserDefinedMacroFunctionMultidimensionalIndexScanComparisonsRangeConstraintsPromoteValue.ArrayCoercionBiFunctionThe
PickValuecase is covered end-to-end by the newCASEqueries inskipped-field-number-proto.yamsql.Fixes #4873.