Repository navigation
Port the record query tests affected by ExplodeValue to yamsql - #4843
Merged
g31pranjal merged 8 commits intoNov 5, 2026
Merged
Conversation
g31pranjal
force-pushed
the
apple/g31pranjal/port-affected-core-tests-to-yamsql
branch
from
November 4, 2026 22:16
e4b7f5b to
099f1da
Compare
g31pranjal
force-pushed
the
apple/g31pranjal/port-affected-core-tests-to-yamsql
branch
from
November 4, 2026 23:56
e203d65 to
f038db0
Compare
g31pranjal
marked this pull request as ready for review
November 5, 2026 00:13
…des assertions The tests ported to yamsql are restricted with @DualPlannerTest(planner = OLD) instead of assuming the old planner in their bodies. DualPlannerExtension now allows such a parameterized test to provide no contexts of its own, since the parameterized extension already runs it with the old planner.
normen662
approved these changes
Nov 5, 2026
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
g31pranjal
deleted the
apple/g31pranjal/port-affected-core-tests-to-yamsql
branch
November 5, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports 37
fdb-record-layer-corerecord query tests to the yamsql suite underyaml-tests/src/test/resources/cascades-query-tests/. A trimmed-down version of #4588 holding only these tests.These are the tests whose
INsource (aLiteralValuelist or a named parameter) is no longer compatible with the Cascades run of the JUnit test after #4816, so their Cascades coverage moves to SQL. The JUnit tests stay in place, are marked with// SQL Port status: (#4843) …, and skip the Cascades run viaAssumptions.assumeFalse(useCascadesPlanner)(FDBInQueryTest) or are restricted to the old planner.What is in the PR
includes/simple-record-100.yamsql, registered inCascadesQueryTests. Metrics are generated for every file.MIGRATION.md(per-method state) andREADME.md, cut down to these three classes.SQL Port status/SQL Portcomments on all 37 JUnit tests.How the
INsource is portedListComparison), orConstantObjectValueIN (…)literal list.AstNormalizerlifts every literal into aConstantObjectValue, so both are the same SQLParameterComparison,equalsParameter)in !! !in {[…]} !!/= !! 0 !!, in a separate test block withstatement_type: prepared(named<file>-prepared)Every query has its own test: nothing is shared between two tests, and each
reverse/p/str_list/ ordering variant is its own query. The remaining parameterizations (InAsOrUnionMode,omitPrimaryKeyInOrdering,replans,normalizeNestedFields,attemptFailedInJoinAsUnionMaxSize) are planner or old-planner settings with no SQL surface and collapse.LIMITis not supported in SQL, sotestInWithLimitpages withmaxRows: 3. Where a variant needs its own schema (dropNumValue3Index), it has its own file.The 37 tests
qNis the position among the executed queries in the file; the-preparedblock follows the literal one.FDBInQueryTest(31)testInQueryNoIndex(0, 2), residual filtertestInQueryNoIndexWithParametervaluesThree, residual filtertestInQueryIndex(1, 2, 4), forward and reversetestInQueryIndexSorted(1, 4, 2)(out of order), forward and reversetestInQueryCoveringIndex(1, 2, 4), forward and reverse, coveringtestInQueryIndexSortedDifferently(1, 4, 2), sorted on another column, forward and reversetestInQueryParametervalueThrees, no sorttestInQuerySortedByParametervalueThrees, forward and reversetestInQueryParameter2valueThrees+equalsParameter("p"), p = 0..4, forward and reversetestInQueryParameter2UsingCoveringIndexScanstestInQueryParameterBadtestListInQuerySortedWithExtraUnorderedColumns(1, 2, 4), forward and reversetestParameterizedInQuerySortedWithExtraUnorderedColumnsequalsParameter, forward and reverseinQueryWithSortBySecondFieldOfCompoundIndex(1, 4, 2)inQueryWithSortAndRangePredicateOnSecondFieldOfCompoundIndex(1, 4, 2)+ rangeinQueryWithSortAndParameterinList+ rangetestInWithNestingtestMultipleInQueryIndexrec_no,path)testMultipleInQueryIndexSortedtestInWithLimitls, returned-row limitmaxRows: 3)testInWithContinuationls, continuationsmaxRows: 1)testInQueryOr(903, 905, 901)OR a rangetestInQueryOrDifferentCondition(2, 0)OR a range, residual filtertestInQueryOrMultipleIndexes(1, 3)OR another indextestInUnionWithNonSargable(1, 3, 5, 7, 9), residual filtertestInQueryEmptyListin ()does not parse)testInQueryOrOverlaptestInQueryOrCompound(1, 3)in OR in ANDtestInUnionWithSomeSargablenv2_list,str_listtestInUnionWithIntersectionOnTwoPredicatesnv2_list,str_list;dropNumValue3Indexchanges the schemaenumInCREATE TYPE AS ENUMFDBPermutedMinMaxQueryTest(4)Each is parameterized over
InComparisonCase:byLiteralandbyConstantObjectValueare the literal block,byParameteris the-preparedblock.selectMaxWithInOrderByMaxtestMaxWithInAndDupestestSortedMaxWithInOnRepeatertestMaxUniqueByStr2And3WithDifferentOrderingKeysFDBSimpleQueryGraphTest(2)testSimpleExistentialPredicateOnSimpleIndext;inComparisonflipsEQUALS/IN=), q2 (IN), preparedtestEqualityAndSimpleExistentialPredicatenameandtTotals: 35 ported, 1 not portable (
testInQueryParameterBad), 1 deferred (enumIn).Notes
main, so plans carry the covering-scan-plus-fetch shape from Push in-joins over comparands through fetches #4830.MAPabove a covering scan. This is documented in the header ofin-query-sorted-extra-unordered-columns.yamsql.