Repository navigation
Describe the planner type of a RecordType, including a synthetic one - #4829
Merged
Merged
Conversation
g31pranjal
marked this pull request as ready for review
November 3, 2026 13:50
robert-brunel
approved these changes
Nov 3, 2026
…t building a collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordMetaData.getPlannerTypetakes record type names and resolves them withgetRecordType, which only knows stored record types. So the planner cannot describe a synthetic record type. In particular,IndexExpansionInfocannot build the base type of an index defined on one.This adds
getPlannerTypeForRecordType(RecordType)andgetPlannerTypeForRecordTypes(Collection<RecordType>), which describe the record types they are given rather than looking them up by name. The name-taking overloads now resolve their names and delegate to them, so their behaviour is unchanged.IndexExpansionInfopasses the indexed record types it already holds.Nothing changes observably yet: indexes on synthetic record types are not offered to the planner. This is groundwork for planning queries against indexes on joined synthetic record types (#4817).
RecordMetaDataPlannerTypeTestcovers three cases: