Repository navigation
Key the index-entry-to-record translation by SQL field name - #4760
Merged
Merged
Conversation
IndexEntryToRecordValueHelper was filled with record descriptor field names but drained by the SQL names of the base record type, so every column of a table with an escaped identifier read NULL. Fill it with the SQL names instead, and make the name/storage-name distinction explicit on FieldValue. Fixes #4758
hatyo
added
bug fix
hatyo
marked this pull request as ready for review
October 19, 2026 14:04
robert-brunel
requested changes
Oct 19, 2026
Rename the FieldValue getters that return record descriptor names to get...StorageName...(), drop the getLastField*Name() shortcuts in favour of getFieldPath(), and document SQL vs storage spelling on each getter. Replace IndexEntryToRecordValueMangledNameTest with a case in IndexEntryTranslatorEquivalenceTest that drives computeIndexEntryToLogicalRecord over a descriptor with escaped field names.
robert-brunel
self-requested a review
November 2, 2026 10:27
robert-brunel
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexEntryToRecordValueHelperwas filled with record descriptor field names but looked up by the SQL names of the base record type, so columns with escaped identifiers readNULL. It is now filled with the SQL names, andFieldValueexposes the name and the storage name separately.The translation has no consumer yet, so the new unit test is the only coverage.
Fixes #4758.