Repository navigation
Resolve flaky test RankIndexTest.concurrentMutationsToRankIndex by disabling unsafe concurrency mode - #4716
Merged
alecgrieser merged 2 commits intoOct 7, 2026
Conversation
…disabling unsafe concurrency mode This updates the tset `RankIndexTest.concurrentMutationsToRankIndex` so that it does not attempt to insert multiple entries into the rank index if the concurrency manager on the store is diabled. The rank index is not currently expected to supported concurrent updates at the moment. We could attempt to better enumerate the classes of failures that concurrent updates might attempt to do, but this seems like a bit of wild-goose chase, so instead, this just modifies the scenarios for the test to avoid the case we don't support (yet). Once we do support it, we can modify the parameters back.
ScottDugas
approved these changes
Oct 6, 2026
ScottDugas
reviewed
Oct 6, 2026
Collaborator
There was a problem hiding this comment.
[ant:checkstyle] [ERROR] /home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/indexes/RankIndexTest.java:74:8: Unused import - com.apple.test.ParameterizedTestUtils. [UnusedImports]
> Task :fdb-record-layer-core:checkstyleMandatory
> Task :fdb-record-layer-core:checkstyleMandatory FAILED
[ant:checkstyle] [ERROR] /home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/indexes/RankIndexTest.java:74:8: Unused import - com.apple.test.ParameterizedTestUtils. [UnusedImports]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the test
RankIndexTest.concurrentMutationsToRankIndexso that it does not attempt to insert multiple entries into the rank index if the concurrency manager on the store is diabled. The rank index is not currently expected to supported concurrent updates at the moment. We could attempt to better enumerate the classes of failures that concurrent updates might attempt to do, but this seems like a bit of wild-goose chase, so instead, this just modifies the scenarios for the test to avoid the case we don't support (yet). Once we do support it, we can modify the parameters back.This fixes #4714.