fix(ci): restore standalone BDK builds (SFT-8127) - #8
Closed
Jacksper13 wants to merge 2 commits into
Closed
Jacksper13 wants to merge 2 commits into
Jacksper13 wants to merge 2 commits into
Conversation
Use the matching Foundation BDK serialization revision across the wallet and examples. Lock compatible dependency versions without removing Rust 1.63 coverage, and bound package installation so mirror failures cannot consume six hours. Preserve Update serialization and cover it with a nonempty roundtrip fixture. Tests, builds, and Clippy are delegated to CI; local verification is limited to formatting, dependency-lock generation, and diff checks.
Coverage Report for CI Build 35088715832Warning No base build found for commit Coverage: 85.061%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the standalone build and fix the existing CI failures exposed by documentation-only PR #7.
Wallet::Updatealready requires. Keep the existing BDK crate versions and serialization support without introducing a broader BDK upgrade.--lockedin CI. Preserve both Rust 1.63 and 1.85 checks, with compatible dependency selections and documented lockfile regeneration.Fromconversion, and add a nonempty wallet-update serialization roundtrip regression test.Scope
No changes to wallet formats, signing policy, or
SECURITY.md. All example backends stay enabled and share the same BDK types. The blocking Esplora example now uses platform trust roots/native TLS instead of bundled webpki roots; certificate/hostname verification remains enabled. This is confined to the example, not a change to downstream applications' TLS selection. Dependency metadata/lockfile changes account for most of the diff; the lockfile is generated by Cargo, not hand-edited.Instead of relying on whichever transitive versions resolve on a given day, CI uses the committed dependency graph. Library consumers still resolve dependencies in their own workspace, so this does not globally pin downstream applications.
Validation
git diff --check.345b47e1, CI passed: the Rust 1.63/1.85 feature matrix, no-std, WASM, all four examples, Clippy, formatting, and the new serialization regression.Dependency follow-ups
The audit's informational warnings remain visible; no advisories are suppressed.
bincode(persisted file-store format),adler(backtrace), andrustls-pemfile(HTTP dependency) are reported as unmaintained. Migrating these is outside this build-repair PR.anyhowalso has an informationaldowncast_mutunsoundness warning (RUSTSEC-2026-0190). There are no calls to that operation in this wallet, its examples, or the selected BDK dependencies. The patched 1.0.103 requires Rust 1.68, versus the wallet's declared 1.63 test baseline. It is a development/example dependency here; updating the MSRV or backporting that fix needs a separate compatibility decision, not an advisory ignore.SFT-8127