added account indices for public descriptor templates - #6
Merged
mjg-foundation merged 1 commit intoApr 20, 2026
Merged
mjg-foundation merged 1 commit into
mjg-foundation merged 1 commit into
Conversation
mjg-foundation
marked this pull request as ready for review
April 19, 2026 17:42
icota
approved these changes
Apr 20, 2026
icota
left a comment
icota
left a comment
There was a problem hiding this comment.
I was gonna say maybe builder pattern instead of a one-off build_account would be nicer but since this is just for our internal usage and the maintenace burden of this approach is lower I think it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: