Skip to content

refactor(fee): remove unused formatFee and its tests (closes #1039) #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdjioe5-cpu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(fee): remove unused formatFee and its tests (closes #1039) #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions __tests__/lib/fee-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { describe, it, expect } from "vitest";
import {
calculateFeeBreakdown,
isHighFee,
formatFee,
calculateBatchFees,
TYPICAL_FEES,
} from "@/lib/fee-utils";
Expand Down Expand Up @@ -51,20 +50,6 @@ describe("isHighFee", () => {
});
});

describe("formatFee", () => {
it("converts stroops to XLM string", () => {
expect(formatFee(10_000_000)).toBe("1.0000000");
});

it("respects decimals parameter", () => {
expect(formatFee(10_000_000, 2)).toBe("1.00");
});

it("handles small fees", () => {
expect(formatFee(100)).toBe("0.0000100");
});
});

describe("calculateBatchFees", () => {
it("multiplies fee per operation by count", () => {
const result = calculateBatchFees(5, 50_000);
Expand Down
8 changes: 0 additions & 8 deletions lib/fee-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ export function isHighFee(fee: number, averageFee: number): boolean {
return fee > averageFee * 2;
}

/**
* Format fee amount for display
*/
export function formatFee(stroops: number, decimals: number = 7): string {
const xlm = stroops / 1e7;
return xlm.toFixed(Math.min(decimals, 7));
}

/**
* Calculate batch operation total fees
*/
Expand Down
Loading