Repository navigation
refactor(fee-utils): name the 15% fee buffer constant (closes #1038) - #1068
Open
jdjioe5-cpu wants to merge 1 commit into
Open
jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1038
This PR addresses the refactoring request in issue #1038 by naming the 15% safety buffer constant used in
lib/fee-utils.ts:const bufferMultiplier = 1.15;into an exported, documented module constant:export const FEE_BUFFER_MULTIPLIER = 1.15;.__tests__/lib/fee-utils.test.tsto assert thatFEE_BUFFER_MULTIPLIERis exported with the expected value (1.15) and replaces inline magic numbers in calculation assertions.Changes
lib/fee-utils.ts: ExportFEE_BUFFER_MULTIPLIER = 1.15and use it insidecalculateFeeBreakdown.__tests__/lib/fee-utils.test.ts: ImportFEE_BUFFER_MULTIPLIER, add dedicated unit test, and use the constant in fee calculation assertions.Verification
__tests__/lib/fee-utils.test.tspass (npx vitest run fee-utils).