Skip to content

chore: remove unused verified token loader (#1032) - #1061

Open
jiangyuer018 wants to merge 1 commit into
FlowwStar:mainfrom
jiangyuer018:chore/1032-remove-unused-token-loader
Open

jiangyuer018 wants to merge 1 commit into
FlowwStar:mainfrom
jiangyuer018:chore/1032-remove-unused-token-loader

Conversation

@jiangyuer018

Copy link
Copy Markdown

Issue

Closes #1032

Claimed before implementation:
#1032 (comment)

Summary

Remove the unused verified-token loader, its cache and private entry type.
The loader requested /lib/tokens.json, which Next.js does not serve.
Delete the unused JSON file after checking every source and test consumer.

Replace the stale loader tests with checks for the existing built-in token
verification and network-specific custom-token lists. Also repair duplicate
imports and unclosed test groups in that same obsolete test section.
The active token-selection and verification implementations are unchanged.

Test plan

  • npm run lint: passes with 14 warnings in unchanged files.
  • npx vitest run __tests__/lib/stellar.test.ts --coverage.enabled=false:
    37 tests pass.
  • No loader, cache, private entry type or token JSON references remain in
    application source or tests; git diff --check passes.
  • npm run typecheck: blocked by syntax errors in seven untouched files.
    Each file also has syntax errors when parsed from base commit 2fdb3f0.
  • npm test -- --reporter=dot: 97 suites and 1,332 tests pass;
    23 suites and 65 tests fail. Failures include the unchanged syntax errors
    and unrelated assertions. The complete suite is not claimed green.
  • npm run build: blocked by the unchanged syntax errors in
    navbar.tsx, stream-timeline.tsx and lib/copy/ modules.
  • Both security scripts fail before scanning on Windows because their
    existing URL.pathname root produces a C:\C:\... path.

Local Node is 22.20.0, below the package's declared 22.22.1 minimum.
No browser or live-network tests were run for this unused-code removal.

Checklist

  • The change is scoped to the linked issue.
  • Tests cover the active token helpers after removing the dead loader.
  • No secrets, private keys or wallet credentials are included.
  • No dependency, configuration or production behavior changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead loadVerifiedTokens() that fetches an unserved /lib/tokens.json

1 participant