Repository navigation
chore: remove unused verified token loader (#1032) - #1061
Open
jiangyuer018 wants to merge 1 commit into
Open
jiangyuer018 wants to merge 1 commit into
jiangyuer018 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1032
Claimed before implementation:
#1032 (comment)
Summary
Remove the unused verified-token loader, its cache and private entry type.
The loader requested
/lib/tokens.json, which Next.js does not serve.Delete the unused JSON file after checking every source and test consumer.
Replace the stale loader tests with checks for the existing built-in token
verification and network-specific custom-token lists. Also repair duplicate
imports and unclosed test groups in that same obsolete test section.
The active token-selection and verification implementations are unchanged.
Test plan
npm run lint: passes with 14 warnings in unchanged files.npx vitest run __tests__/lib/stellar.test.ts --coverage.enabled=false:37 tests pass.
application source or tests;
git diff --checkpasses.npm run typecheck: blocked by syntax errors in seven untouched files.Each file also has syntax errors when parsed from base commit
2fdb3f0.npm test -- --reporter=dot: 97 suites and 1,332 tests pass;23 suites and 65 tests fail. Failures include the unchanged syntax errors
and unrelated assertions. The complete suite is not claimed green.
npm run build: blocked by the unchanged syntax errors innavbar.tsx,stream-timeline.tsxandlib/copy/modules.existing
URL.pathnameroot produces aC:\C:\...path.Local Node is 22.20.0, below the package's declared 22.22.1 minimum.
No browser or live-network tests were run for this unused-code removal.
Checklist