Repository navigation
test: add coverage for notification/address-book UI, fix landing E2E strict-mode violation - #1025
Merged
Austinaminu2 merged 1 commit intoOct 18, 2026
Conversation
…strict-mode violation - NotificationPreferencesSettings: cover per-type toggle rendering and that toggling persists through useNotificationPreferences. - AddressBookSettings: cover rendering saved entries, edit->save updating an entry, and delete removing an entry. - NotificationBell: cover unread badge count, open/close toggle, click outside, Escape, and per-notification title/body rendering. - e2e/landing.spec.ts: replace the ambiguous `text=FlowStar` locator (matches 7 elements) with a scoped locator on the banner's brand link. Closes FlowwStar#914 Closes FlowwStar#912 Closes FlowwStar#911 Closes FlowwStar#906 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Samson-Starlion
had a problem deploying
to
staging
October 18, 2026 14:44 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
@Samson-Starlion Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationPreferencesSettings: added tests covering that a toggle renders per notification type, and that toggling one persists throughuseNotificationPreferences(localStorage).AddressBookSettings: added tests covering rendering of saved entries, edit → save updating an entry's label, and delete removing an entry.NotificationBell: added tests covering the unread badge count, open/close toggle, click-outside dismissal, Escape dismissal, and per-notification title/body rendering.e2e/landing.spec.ts: replaced the ambiguouspage.locator('text=FlowStar')(matched 7 elements — header brand, footer brand, and body copy) with a locator scoped to the brand link inside the page banner, resolving the strict-mode violation.No production code changes were needed for the test issues (#914, #912, #911) — all behavior already matched the acceptance criteria once covered by tests.
Test plan
npm testpasses with the new specs under__tests__/components/npx playwright test e2e/landing.spec.tspasses on chromium-desktopCloses #914
Closes #912
Closes #911
Closes #906
🤖 Generated with Claude Code