Repository navigation
Fix: 4 issues (#937, #939, #940, #941) - #1018
Merged
Merged
Conversation
Co-authored-by: Simple Agent <agent@simple.dev>
|
@topsonDev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #937
Closes #939
Closes #940
Closes #941
Issues
#937 Test verified token list helpers
#939 Test formatTimeAgo
#940 Add tests for the Tabs UI component
#941 Contract: test remove_delegate is rejected while paused
Summary
All frontend tests must live under tests/ (only that directory is collected by Vitest). For lib/stellar.ts, loadVerifiedTokens is not exported and uses a module-level cache — test it indirectly via getAllTokens/isVerifiedToken or use vi.resetModules() + dynamic import; mock global.fetch and @/lib/sentry. For formatTimeAgo, pin Date.now with fake timers for deterministic output. For the contract test, confirm the exact paused error variant name in lib.rs (require_not_paused) before asserting; the try_* client returns Result<Result<T, StreamError>, _> so the assertion is Err(Ok(StreamError::...)). No production code changes are expected; if a bug is found, note it in the PR.
Changes