For Channels opened via ipc::session, ensure the socket-stream-specific method remote_peer_process_credentials() returns values relevant to the opposing process despite the details of how such channels are internally established (namely via socketpair()). / Add Native_socket_stream::remote_peer_process_credentials() mutator that allows one to correct this value when creating socket-streams more manually (such as is done internally by ipc::session).#155
Merged
Conversation
… opened via `ipc::session`, ensure the socket-stream-specific method `remote_peer_process_credentials()` returns values relevant to the opposing process despite the details of how such channels are internally established (namely via `socketpair()`). / Add `Native_socket_stream::remote_peer_process_credentials()` mutator that allows one to correct this value when creating socket-streams more manually (such as is done internally by `ipc::session`).>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #148
When writing Release Notes: put the PR Title's contents into the proper little sections. I did not make this PR until a year after doing/reviewing/merging it in source dir (my mistake to wait that long, until other bigger work applied pressure to line things up), so slightly cutting some formalistic corners (I promise, just this PR's format).
Code review: done in submodules