-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat(effort-graph): add Citation + Blob with optional blob cites #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
.flatbread-efforts/blobs/blb-blob-cite-design-notes--j3jbgc0cymdb2t9g.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| id: blb-blob-cite-design-notes--j3jbgc0cymdb2t9g | ||
| effort: eff-effort-graph-memory-and-agent-wedge--szeqvmgqjqnhd002 | ||
| title: Blob cite design notes | ||
| kind: markdown | ||
| created_at: '2026-07-19T11:21:00.970Z' | ||
| --- | ||
|
|
||
| # Blob + Citation dogfood | ||
|
|
||
| Longform notes for the citeable payload slice. | ||
|
|
||
| - Citations are first-class refs targets | ||
| - Blob is optional on Citation | ||
| - Citation body may be a URL alone |
9 changes: 9 additions & 0 deletions
9
.flatbread-efforts/citations/cit-flatbread-refs-docs-intent--ew3x4qpx1x3c1cy2.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| id: cit-flatbread-refs-docs-intent--ew3x4qpx1x3c1cy2 | ||
| effort: eff-effort-graph-memory-and-agent-wedge--szeqvmgqjqnhd002 | ||
| title: Flatbread refs docs intent | ||
| role: context | ||
| created_at: '2026-07-19T11:21:02.547Z' | ||
| --- | ||
|
|
||
| https://github.com/FlatbreadLabs/flatbread |
10 changes: 10 additions & 0 deletions
10
.flatbread-efforts/citations/cit-local-blob-design-dump--pg7g6qy1td7yjqpy.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| id: cit-local-blob-design-dump--pg7g6qy1td7yjqpy | ||
| effort: eff-effort-graph-memory-and-agent-wedge--szeqvmgqjqnhd002 | ||
| title: Local blob design dump | ||
| role: evidence | ||
| blob: blb-blob-cite-design-notes--j3jbgc0cymdb2t9g | ||
| created_at: '2026-07-19T11:21:04.044Z' | ||
| --- | ||
|
|
||
| Repo dogfood blob capturing the Citation/Blob split. |
33 changes: 33 additions & 0 deletions
33
.../decisions/dec-ship-citation-collection-with-optional-blob--fyga3x876n7rcnmn.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| id: dec-ship-citation-collection-with-optional-blob--fyga3x876n7rcnmn | ||
| effort: eff-effort-graph-memory-and-agent-wedge--szeqvmgqjqnhd002 | ||
| title: Ship Citation collection with optional Blob | ||
| state: accepted | ||
| created_at: '2026-07-19T11:21:07.225Z' | ||
| derives_from: | ||
| - fnd-citation-collection-keeps-flatbread-refs-intact--z33ar5vyjxzr7ys0 | ||
| - iss-implement-blob-collection-and-crumb-graph-cites--g2c7m6j39we5xy3z | ||
| cites: | ||
| - cit-local-blob-design-dump--pg7g6qy1td7yjqpy | ||
| --- | ||
|
|
||
| ## Context | ||
|
|
||
| Epistemic records need cite metadata without breaking Flatbread homogeneous refs (string ids only). | ||
|
|
||
| ## Decision | ||
|
|
||
| Add Citation as a first-class collection. Epistemic records use cites→Citation. Citation body alone is valid (e.g. URL). Optional blob→Blob attaches longform payloads. No cite_meta sidecar. | ||
|
|
||
| ## Alternatives considered | ||
|
|
||
| - cite_meta objects alongside cites→Blob: works but bypasses refs for annotations | ||
| - cites→Blob only: no place for relationship/URL-only cites | ||
|
|
||
| ## Consequences | ||
|
|
||
| WriteCitation + WriteBlob mutations; digests omit Blob bodies by default. | ||
|
|
||
| ## Reversal criteria | ||
|
|
||
| Revisit if Citation churn is too heavy for simple URL cites or if polymorphic cite targets become necessary. |
14 changes: 14 additions & 0 deletions
14
...ndings/fnd-citation-collection-keeps-flatbread-refs-intact--z33ar5vyjxzr7ys0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| id: fnd-citation-collection-keeps-flatbread-refs-intact--z33ar5vyjxzr7ys0 | ||
| effort: eff-effort-graph-memory-and-agent-wedge--szeqvmgqjqnhd002 | ||
| title: Citation collection keeps Flatbread refs intact | ||
| kind: measurement | ||
| created_at: '2026-07-19T11:21:05.639Z' | ||
| derives_from: | ||
| - iss-implement-blob-collection-and-crumb-graph-cites--g2c7m6j39we5xy3z | ||
| cites: | ||
| - cit-flatbread-refs-docs-intent--ew3x4qpx1x3c1cy2 | ||
| - cit-local-blob-design-dump--pg7g6qy1td7yjqpy | ||
| --- | ||
|
|
||
| Homogeneous cites→Citation (optional blob; URL body alone is valid) preserves core refs validation and GraphQL resolve without cite_meta sidecars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIGH — Prerequisites still list only six record folders (
efforts…risks). Opening copy above the hunk still says “Six primitives” / “13 typed mutations” while this file later documents 15 mutations and Citation/Blob.Minimal fix: Extend this path list to include
citations/blobs, and update the opening paragraph + YAMLdescriptionto eight collections / 15 mutations (syncpackages/effort-graph/skills/…copy).