Repository navigation
chore: stop tracking generated utils/version.ts - #429
Open
matthewelwell wants to merge 1 commit into
Open
matthewelwell wants to merge 1 commit into
matthewelwell wants to merge 1 commit into
Conversation
matthewelwell
force-pushed
the
chore/release-please-sdk-version
branch
from
October 6, 2026 08:05
d289c7b to
4e5765c
Compare
matthewelwell
changed the title
utils/version.ts is a build artifact generated by write-version.js, and .gitignore:45 says so. It was nonetheless committed in the same PR that added the ignore rule (#332), so the rule has never had any effect: the file is tracked, shows as modified after every build, and its committed contents drifted to 11.0.0 against a 12.4.0 package. Published packages were never affected - publish.yml and pull-request.yml both run `npm run build`, whose prebuild step regenerates the file from lib/flagsmith/package.json. The published @Flagsmith/flagsmith@12.4.0 correctly embeds 12.4.0. Untrack it so the ignore rule applies. Nothing generated it on install, so `npm test` and `npm run typecheck` would fail on a fresh clone with "Cannot find module './utils/version'"; generating it from `prepare` fixes that, since npm runs prepare after `npm i`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
matthewelwell
force-pushed
the
chore/release-please-sdk-version
branch
from
October 6, 2026 08:57
4e5765c to
44c9262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils/version.tsis a build artifact generated bywrite-version.js, and.gitignore:45says so — but it was committed in the same PR that added the ignore rule (#332), so the rule never took effect. It shows as modified after every build, and its committed contents had drifted to11.0.0against a12.4.0package. Published packages were never affected (@flagsmith/flagsmith@12.4.0correctly embeds12.4.0), since both workflows runnpm run buildand its prebuild step regenerates the file.Untracking it means a fresh clone has no
utils/version.tsand nothing generates it beforenpm test/npm run typecheck, which then fail withCannot find module './utils/version'— so generation moves toprepare, which npm runs afternpm i.🤖 Generated with Claude Code