Repository navigation
Read native ledring.trace.v1 files directly - #102
Merged
Merged
Conversation
New ledring-trace adapter: a file that already holds normalized runs (one Run, an array, or JSONL) now works with every command, including ledring mcp. Missing step signatures are filled with signatureOf, so an exporter only has to get the schema right. This is what research.ledring.dev's trace export targets. Adds a small research-run fixture plus adapter and CLI tests.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now LEDRING could only read Claude Code JSONL, OTel GenAI spans and decisions logs, so a tool that exports straight to
ledring.trace.v1had nowhere to go.ledring-traceadapter: one Run object, an array of runs, or JSONL. Detected byschema === "ledring.trace.v1"only, so it can't shadow other adapters. Missing stepsignatures are filled withsignatureOf. Extra top-level fields are ignored (ADR 0002).ledring mcp.fixtures/native/research-run.ledring.json+ adapter tests (object/array/JSONL, signature fill, bad schema rejected) and a CLI test forflowchart --json/instability --json.Local: lint, typecheck, build,
pnpm test(40 files / 285 tests), i18n, capability contracts, motion lint, release dry-run all pass.