fix: translation of components containing private fields - #543
Open
breezertwo wants to merge 1 commit into
Open
breezertwo wants to merge 1 commit into
breezertwo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested fix for #542
Explicitly selecting private component fields causes Strapi to reject translation queries with
Invalid key <field>.This PR removes the generated component
fieldslists and uses Strapis Document Service default selection, preserving required private values and existing nested population rules.I validated the changes against my local strapi, added some dedicated tests & and all other tests still pass.
The five modified tests had to drop the removed
fieldskey.