Skip to content

fix(test): build and format the teacher call comparison tests - #60

Merged
FeathBow merged 1 commit into
mainfrom
fix/comparisons
Oct 12, 2026
Merged

FeathBow merged 1 commit into
mainfrom
fix/comparisons

Conversation

@FeathBow

Copy link
Copy Markdown
Owner

Why

The comparison tests for teacher calls did not build, so the core test suite on main failed to compile:

  • test/Comparisons.hs imported Invar.Learn.Request, which the library does not expose;
  • a local binding named retried shadowed the test of the same name, which the warnings policy rejects;
  • teacherSample was not in the project's Fourmolu format.

What

  • The test checks that admission keeps a changed teacher call through Report.request, the value of the report's checked request, instead of the hidden request module. The library's exposed modules do not change.
  • The local binding is renamed to renumbered.
  • teacherSample is formatted with Fourmolu.

Validation

  • All six comparison tests pass, including both teacher call tests.
  • The core suite, type fixtures, Fourmolu, HLint, confidence bounds, actionlint, cabal check, sdist, and the shared, Hugging Face and MLX worker suites passed.

Signed-off-by: Feathbow <feathbow@gmail.com>
@FeathBow
FeathBow merged commit 1748f94 into main Oct 12, 2026
3 checks passed
@FeathBow
FeathBow deleted the fix/comparisons branch October 12, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant