Repository navigation
fix(test): build and format the teacher call comparison tests - #60
Merged
Merged
Conversation
Signed-off-by: Feathbow <feathbow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The comparison tests for teacher calls did not build, so the core test suite on
mainfailed to compile:test/Comparisons.hsimportedInvar.Learn.Request, which the library does not expose;retriedshadowed the test of the same name, which the warnings policy rejects;teacherSamplewas not in the project's Fourmolu format.What
Report.request, the value of the report's checked request, instead of the hidden request module. The library's exposed modules do not change.renumbered.teacherSampleis formatted with Fourmolu.Validation
cabal check, sdist, and the shared, Hugging Face and MLX worker suites passed.