Conversation
Collaborator
Author
|
I am unsure why this is failing. |
ctrlaltf24
reviewed
Aug 10, 2026
ctrlaltf24
left a comment
ctrlaltf24
left a comment
Contributor
There was a problem hiding this comment.
Started review. Only until last comment.
Contributor
There was a problem hiding this comment.
nit(file name): 'actions' doesn't describe much - it's vague. Does that word add value?
Comment on lines
+14
to
+16
| def get_logos_paths( | ||
| ephemeral_config: EphemeralConfiguration, | ||
| ) -> LogosPaths: |
Contributor
There was a problem hiding this comment.
Good call leaving this out of app so we can do operations before the app is initialized
Comment on lines
+43
to
+44
| def get_logos_databases(ephemeral_config: EphemeralConfiguration) -> list[Path]: | ||
| return get_logos_paths(ephemeral_config).databases |
Contributor
There was a problem hiding this comment.
Is this function helping? get logos paths calls get wine user with does filesystem operations. The caller is better off calling get logos paths once then calling databases themselves
| return get_logos_paths(ephemeral_config).databases | ||
|
|
||
|
|
||
| def database_operation(ephemeral_config: EphemeralConfiguration): |
Comment on lines
+113
to
+117
| def database_notes_get_operation(ephemeral_config: EphemeralConfiguration): | ||
| paths = get_logos_paths(ephemeral_config) | ||
| with NotesDatabase(paths.appdata, paths.user_id) as db: | ||
| note = db.get_note(ephemeral_config.note_id) | ||
| print(note) |
Contributor
There was a problem hiding this comment.
Seem to be a lot of functions that just print. These will be used how?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #178.
Implements a CLI subparser and modules that uses the Logos SQL databases to create Markdown notes of the user's content. The content is stored in <install_dir>/export. The output is designed around a flat file storage system made to work with Neovim and Obsidian. Three kinds of files are created:
The code generates a basic link to the Logos resource. Due to the way data is stored, nothing more can be achieved for the Logos resource (i.e., location within a resource).
Some data in the above YAML header could be removed (resource_id, logosres_id).
Other tooling in this commit includes additional refactoring splitting up files, and also adding reusable SQL database functions.
Basic usage:
Additional options have been implemented. Use
--helpalong the way.I intentionally did not implement a TUI command. If the GUI is intro level, and the TUI is advanced user, then the CLI is power user. It wouldn't be hard to add a TUI option or GUI button, I suppose, just for the basic export command.
The goal here is to be able to retrieve Logos notes in a one-way fashion. Some data loss will happen, but less than if I never accessed my Logos notes again due to them being outside of the current system. I want to be able to access the notes I have created in order to convert them to my existing note-taking system (flat file markdown accessed via neovim).