feat: keep track of network failures - #484
Draft
ctrlaltf24 wants to merge 1 commit into
Draft
Conversation
@offline_aware guards NetworkRequests methods: a ConnectionError marks the instance offline for 2 minutes and raises NetworkOffline. A decorator wraps each method so the offline check and try/except frame the body once, instead of repeating the same rule inside every method. Co-authored-by: MiniMax-M3 <noreply@MiniMax-M3.ai>
ctrlaltf24
marked this pull request as draft
July 20, 2026 22:53
Contributor
Author
|
PR made for demonstration purposes more than an intent to merge. FYI @thw26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft demonstrating how decorators can be used to facilitate not repeating the try except catches across the repo
@offline_aware guards NetworkRequests methods: a ConnectionError marks
the instance offline for 2 minutes and raises NetworkOffline. A
decorator wraps each method so the offline check and try/except frame
the body once, instead of repeating the same rule inside every method.
Ai generated untested