feat: polish backup/restore guards, sizing, and progress - #472
Draft
ctrlaltf24 wants to merge 1 commit into
Draft
Conversation
- Re-prompt for a new backup location instead of crashing when the configured destination is missing/inaccessible (catches both FileNotFoundError and PermissionError; snap removable-media hint). - Offer to stop a running Logos/indexer before backup/restore. - Confirm with human-readable sizes (data to copy, existing destination data, free space) before the destructive prepare step. - Fix progress never updating in the TUI by varying the status message each tick (also shows copied/total sizes); add utils.format_bytes. Testing done: ruff clean; mypy no new errors; full unittest suite passes (64 pass/16 skip) incl. existing backup tests and new test_format_bytes. Testing needed: manual run in an installed Logos environment to confirm the missing-disk re-prompt, the running-app guard, the size confirmation, and live progress in the TUI/GUI/CLI frontends. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: AI generated- needs human test pass
Testing done: ruff clean; mypy no new errors; full unittest suite passes (64 pass/16 skip) incl. existing backup tests and new test_format_bytes.
Testing needed: manual run in an installed Logos environment to confirm the missing-disk re-prompt, the running-app guard, the size confirmation, and live progress in the TUI/GUI/CLI frontends.
Fixes: #197 #405