test(agents): committed-rename recovery challenge pack - #1
Draft
Audacity88 wants to merge 2 commits into
Draft
Audacity88 wants to merge 2 commits into
Audacity88 wants to merge 2 commits into
Conversation
| && cargo test --offline --no-run --test committed_agent_rename \ | ||
| && cargo test --offline --no-run -p zeroclaw-gateway --lib | ||
|
|
||
| CMD ["bash"] |
Package a fail-to-pass harness for one recovery contract shared by the CLI, gateway, and RPC after an agent rename has already committed. Co-authored-by: Dan Gilles <Audacity88@users.noreply.github.com>
Record that both patches still apply on fb116d6. Co-authored-by: Dan Gilles <Audacity88@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master(all contributions)artifacts/test.patchadds the harness and hidden tests.artifacts/solution.patchis the reference fix and is not applied on this branch.master(fb116d612). The original issue pinc1e79a774is the parent of that master commit. The only commit this work adds is theartifacts/pack.solution.patch. That patch changes CLI, gateway, and RPC agent rename/create so they share one recovery record.Testing (required)
How you can test (when useful)
cli(zeroclaw agents rename/agents create), gateway config map-key rename and create, RPCconfig/map-key-renameandconfig/map-key-createcargo fetch --locked)git apply artifacts/test.patch./test.sh --output_path /tmp/junit-base.xml baseand confirm a non-zero exitgit apply artifacts/solution.patch./test.sh --output_path /tmp/junit-new.xml newand confirm exit 0master(before): withoutsolution.patch, the CLI reports a committed rename as an invalid or missing alias, and an unreadable follower does not block recreating the retired alias.How I tested
test.shcovers the CLI binary plus the gateway lib tests namedcommitted_rename.docker build -f artifacts/Dockerfile .was not run. The fail-to-passtest.shruns were on the original pin, before the rebase ontofb116d612. After the rebase, both patches still apply (git apply --check)../test.sh ... base→ exit1, JUnittests="12" failures="12";./test.sh ... new→ exit0, JUnittests="12" failures="0"fb116d612:git apply --checksucceeded for both patches. Their path sets are disjoint (7 solution files, 5 test files).cursor/committed-rename-recovery-4295rebased ontofb116d612test.patchmade all 12 harness tests fail on the pin; applyingsolution.patchas well made all 12 pass. Both patches still apply on updated master.cargo testand./dev/ci.sh allwere skipped because the harness targets are the changed surface. The suite was not re-run after the rebase because master's new commit does not touch the rename handlers. Docker image build was skipped.Security & Privacy Impact (required)
Yes, describe the risk and mitigation:The committed tree only adds the challenge pack. The unapplied solution patch reads and writes recovery state under the existing data directory and does not add a network surface.
Compatibility (required)
Noor either surface/floor question isYes: exact upgrade steps for existing users:This branch does not apply
solution.patch. Applying that patch changes rename/create behavior for the CLI, gateway, and RPC as described inartifacts/task_prompt.txt.Rollback (required for medium/high-risk PRs)
Low-risk PRs:
git revert <sha>is the plan unless otherwise noted.git revertof the artifacts commit removes the pack. No feature flag.