Repository navigation
Add page and onLoadSuccess props to PDFPreviewer - #59
Closed
ishpaul777 wants to merge 1 commit into
Closed
ishpaul777 wants to merge 1 commit into
ishpaul777 wants to merge 1 commit into
Conversation
Lets consumers show a specific page and know when the document is ready, so callers can flip pages without exposing the internal list ref.
45 tasks done
Contributor
Author
|
Not needed anymore: the App PR renders the visible page directly with react-pdf, so it no longer depends on these props. See Expensify/App#102776 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds two optional props to
PDFPreviewer, so App can flip through pages of a multi-page PDF receipt.page: the 1-indexed page to show. The previewer scrolls to it whenever it changes, including after the document finishes loading, so a page requested early isn't lost.onLoadSuccess: fires once every page has been measured, i.e. when the pages can actually be shown. It's called through a ref, because measuring a large PDF can take seconds and the caller may have re-rendered with a new callback in the meantime.Both props are optional. When they're left out, behaviour is unchanged, so existing callers aren't affected.
Related Issues
Expensify/App#102435
Manual Tests
No automated tests in this repo. Tested through the App PR below: copied this build into App's
node_modules, opened a 106-page PDF receipt, and confirmed the pill appears once the PDF loads and that previous/next scroll to the right page. Also checked that the full-screen PDF viewer, which passes neither prop, behaves as before.Linked PRs
Expensify/App#102776