Unpin the contact method child screens from the profile

[mukhrr]

Explanation of Change

#100292 unpinned the contact methods list from SETTINGS.PROFILE.ROOT so its background follows the base path, but left the three screens that hang off it pinned: DYNAMIC_CONTACT_METHOD_DETAILS, DYNAMIC_NEW_CONTACT_METHOD and DYNAMIC_NEW_CONTACT_METHOD_CONFIRM_VALIDATE_CODE. getMatchingFullScreenRoute checks the relation maps before the dynamic base-path branch, so on a fresh load of a URL whose base is itself an RHP (/e/:reportID, /search/r/:reportID, /search/view/:reportID) the pinned entry wins and the background resolves to Account > Profile.

In-app navigation never hit this, because linkTo skips the full-screen matching block while an RHP is already on top. That is why the background only jumps on refresh, and why #100292 looked complete.

All three hang off CONTACT_METHODS, which declares entryScreens: ['*'], so they can sit over any base path and none of them should name a central pane. Deep links under /settings/profile/contact-methods still resolve the settings split, since the base path itself resolves it.

Fixed Issues

$ #100765
PROPOSAL:

Tests

Use an account with no phone number contact method, so the "Add your number" link is rendered.

1. Open a workspace chat and create an expense.
2. Open the report.
3. Note which page is behind the expense, then refresh the page and confirm the same page is still behind it. This is the background the next steps are compared against.
4. Click "Add your number" on the add receipt modal.
5. Click on the contact email.
6. Refresh the page.
7. Verify the background is the same page as in step 3, and has not changed to Account > Profile.
8. Click the back button, then click "New contact method".
9. Refresh the page.
10. Verify the background is again the same page as in step 3.

• Verify that no errors appear in the JS console

Offline tests

The change only affects which full screen is resolved under the right hand panel on a fresh load, so it has no network surface. Going offline before step 1 and repeating the flow gives the same result, and the background still matches step 3 after each refresh.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]