Skip to content

Remove unsafe assertions from navigation and debug helpers - #100768

Draft
KJ21-ENG wants to merge 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/batch1-group1-43192ddd
Draft

Remove unsafe assertions from navigation and debug helpers#100768
KJ21-ENG wants to merge 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/batch1-group1-43192ddd

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replace unsafe assertions in navigation and developer debugging helpers with producer-derived types, category-preserving state reconstruction and local field checks. The parser accepts the strings its callers already produce; debug reads retain legacy-message priority and intentionally add synchronous-callback support and duplicate-callback suppression.

Changed files:

  • src/libs/Navigation/helpers/getAdaptedStateFromPath.ts
  • src/libs/Navigation/helpers/getPathFromState.ts
  • src/libs/Navigation/helpers/getStateFromPath.ts
  • src/libs/Navigation/helpers/linkTo/getMinimalAction.ts
  • src/libs/Navigation/helpers/linkTo/index.ts
  • src/setup/addUtilsToWindow.ts

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

Passed: 146 tests in 13 existing Jest suites, 34 runtime/falsifier groups, focused lint, formatting and spelling. Fork checks passed typecheck, lint, format, React Compiler and Jest. Local TypeScript was waived: zero changed-file diagnostics, but 43 imported-file diagnostics prevented complete coverage. Focused lint retains four existing support-file warnings.

Probes cover dispatch ordering, full/partial state metadata, strict report IDs, legacy lookups and callback timing. URL encoding and decoding retain delimiter collision handling and query precedence. Extracted probes do not establish Babel integration, browser history or native gestures; Jest coverage is bounded. No committed tests were added.

Local manual testing remains pending: follow QA steps below; on a nonproduction browser report screen, await window.report, window.transaction, window.policy and window.receipt. Verify matching available records and undefined for missing records; use Onyx.get/log with that report's stored key and verify the returned/logged value.

  • Verify that no errors appear in the JS console

Offline tests

Pending: load a report and attachment online, disconnect, repeat cached navigation and back actions. Expect cached content and the same report context; verify again after reconnecting.

QA Steps

Manual QA required. QA before review: shared navigation branches control deep links, tab backgrounds and history. Pending on staging, using desktop/mobile browsers and iOS/Android native:

  1. From Inbox, open a report-action link and attachment; close it and use browser back/forward or native back/swipe. Expect the corresponding report/action and prior screen.
  2. From Settings, open a report deep link; go back. Expect Settings restored. Open a workspace right-hand panel; expect the correct workspace background and nested history.
  3. Open a public deep link signed out, then a report link signed in. Expect the corresponding accessible destination.
  • Verify that no errors appear in the JS console

PR Author Checklist

Manual, offline, failure-flow, high-traffic and all-platform checks remain unperformed. No UI, copy, styles, assets, generic components or Storybook changes require conditional checks.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Not captured; manual QA is pending.

Seatbelt-Operation: s08-43192ddd-4541881-sign-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant