Give App coding standards a unique skill name

[tylerkaraszewski]

Explanation of Change

This gives App's coding standards the unique name app-coding-standards so they don't collide with another repository's coding-standards skill in OpenCode. The 48 rule files are unchanged; review prompts, contributing guides, and the ESLint diagnostic now point to the renamed directory, and skill/reviewer descriptions explicitly identify App as their scope.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/680217
PROPOSAL: N/A - internal tooling.

Tests

1. Run git diff --summary --find-renames 2b61335312740df6c0c754cff4c7f50a4ea527ad HEAD -- .claude/skills and confirm all 48 rule files are renamed with 100% similarity.
2. Inspect .claude/skills/app-coding-standards/SKILL.md and confirm its name is app-coding-standards, its description is App-scoped, and alwaysApply: true is preserved.
3. Follow the relative rule links from the renamed skill and its rules and confirm they resolve.
4. Run git grep -n -I -E '(^|[^a-zA-Z0-9_-])coding-standards([^a-zA-Z0-9_-]|$)' and confirm there are no obsolete skill references (exit status 1 means no matches).
5. Inspect the renamed paths in the review agent, review command, contributing guides, and ESLint diagnostic and confirm they point to app-coding-standards.
6. Run node --experimental-default-type=module --check eslint-plugin-local-rules/no-direct-pre-insert-fullscreen-under-rhp.js and confirm it passes.
7. Run git diff --check 2b61335312740df6c0c754cff4c7f50a4ea527ad..HEAD and confirm it passes.
8. Start OpenCode or Claude Code in the App worktree, load app-coding-standards, and read rules/perf-1-no-spread-in-renderitem.md relative to the skill. Confirm the App skill and rule contents are returned.
9. Repeat from an isolated Expensidev checkout with all three source rename branches and refreshed skill symlinks. Confirm all three repository skills load independently; Claude Code uses the generated AutoLoad directory names at this root.

JS console checks are N/A; this changes source skill metadata and documentation paths, not application behavior.

• Verify that no errors appear in the JS console

AI Tests

The local source validator passed against the base commit:

PASS: all 49 source files moved; 48 rule files byte-identical to 2b61335312740df6c0c754cff4c7f50a4ea527ad.
PASS: valid YAML frontmatter, unique rule IDs, App-scoped skill name/description, alwaysApply preserved.
PASS: 52 relative links resolve; skill body unchanged apart from its App-scoped heading.
PASS: no obsolete skill references; all 7 referring files updated.
PASS: 5 documentation links and 48 reviewer template links resolve; review metadata is App-scoped.
PASS: ESLint module loads, its diagnostic link resolves, and all other rule code is unchanged.

JavaScript syntax and git diff --check also passed. No workflows needed path changes. Markdown is excluded by the repository's Oxfmt configuration.

Live verification passed in OpenCode 1.18.20 and Claude Code 2.1.261, both in the App worktree and in the combined aggregate fixture. Actual skill and relative-rule tool output matched the source files. The aggregate exposed all three renamed coding standards independently.

npm run lint-changed, npm run spell-changed, the targeted NoDirectPreInsertFullscreenUnderRHPRuleTest.ts Jest run, and the offline Oxfmt check could not run because the fresh worktree lacks the required dependencies. I did not install the full application dependency tree or run application builds for this rename.

Offline tests

N/A - no application runtime or network behavior changes.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

N/A - internal tooling only; the tracking issue is titled [No QA] Prevent coding-standards skills from overwriting each other in OpenCode. No staging or production application testing is required. JS console checks are N/A.

• Verify that no errors appear in the JS console

PR Author Checklist

Unchecked application, platform, offline, high-traffic, UI, screenshot, and user-flow test items below are N/A for this internal tooling rename; they were not performed. Tooling checks that could not run are documented above.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - no application UI changes.

Android: mWeb Chrome

N/A - no application UI changes.

iOS: Native

N/A - no application UI changes.

iOS: mWeb Safari

N/A - no application UI changes.

MacOS: Chrome / Safari

N/A - no application UI changes.

[melvin-bot]

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]