[No QA] Docs updates for E/A#86864 Merchant Rule behavior when applied tag is deleted - #100743
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#86864 Merchant Rule behavior when applied tag is deleted#100743MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Follow-up to #86864. Co-authored-by: truph01 <truph01@users.noreply.github.com>
52 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://31a364a0.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #86864, which changed how a Merchant Rule behaves when the tag it applies is deleted from the workspace. After that PR, the rule keeps its stored tag value but the deleted tag is no longer shown in the rule summary or the rule edit page, and matching expenses no longer get a system message with an empty tag. That PR also filters the tag options in a rule so only tags valid under the already-selected parent levels are listed.
docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md:Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one workflow per article, task-based##headings, no new#headings, bolded UI labels in Sentence case, and a relative cross-link.UI labels (Merchant section, Add merchant rule, Save rule, Tag) were checked against the strings in
src/languages/en.ts. The live UI check could not be completed in this run because the test session never rendered the app, so please confirm the labels when you review.Fixed Issues
$ #82690
PROPOSAL:
Docs follow-up for #86864.
Tests
// TODO: The human co-author must fill this out before marking this PR as "ready for review". This PR changes help site markdown only, with no product code changes.
Offline tests
N/A - help site markdown only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// The human co-author must fill out the QA steps before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.