Skip to content

[Due for payment 2026-07-06] [Onyx bump] Bump react-native-onyx from 3.0.85 to 3.0.86 #94684

Closed

Description

@mountiny

Problem

Onyx write paths that flow through retryOperation (mergeCollectionWithPatches, multiSetWithRetry, setCollectionWithRetry, partialSetCollection) had two pre-existing bugs: (1) a brand-new key was silently downgraded from Storage.multiSet to Storage.multiMerge on retry, and (2) keysChanged/keyChanged re-fired on every retry attempt, double-notifying Onyx.connect({waitForCollectionCallback: true}) subscribers. This could cause stale UI or duplicate subscriber invocations when IndexedDB writes fail and retries kick in.

Solution

Bump react-native-onyx from 3.0.85 to 3.0.86, which includes react-native-onyx#792. Each refactored write path now splits into an outer orchestrator (cache update, subscriber notification, and storage prep — called once) and a file-private write helper that retryOperation re-enters, ensuring the cache stays consistent and subscribers fire exactly once per logical write.

PR

#94449

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  2. added
    ReviewingHas a PR in review
    and removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jun 26, 2026
  3. mallenexpensify commented on Jun 28, 2026

    @mallenexpensify
    Contributor

    D'oh, thought this was on production. @Krishna2323 Please comment and tag me if/when payment is due, thx

  4. 2 remaining items

  5. changed the title [-][Onyx bump] Bump react-native-onyx from 3.0.85 to 3.0.86[/-] [+][Due for payment 2026-07-06] [Onyx bump] Bump react-native-onyx from 3.0.85 to 3.0.86[/+] on Jun 29, 2026
  6. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.21-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-06. 🎊

    For reference, here are some details about the assignees on this issue:

  8. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 2, 2026
  10. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. melvin-bot commented on Jul 5, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. Krishna2323 commented on Jul 6, 2026

    @Krishna2323
    Contributor

    @mallenexpensify this is ready for payments. No checklist required here.

  13. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Krishna2323 due $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions