Skip to content

Improve retryOperation and reportStorageQuota logging to include original error #87780

Closed

Description

@Julesssss

OnyxUtils.retryOperation and OnyxUtils.reportStorageQuota can log messages that omit the original storage error. This forces investigators to search nearby logs by timestamp to find the actual failure.

Update logging in both functions to always include the original error in every log path, making it directly queryable in Sentry and VictoriaLogs.

Parent issue: #85252

Issue OwnerCurrent Issue Owner: @fabioh8010

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Apr 13, 2026
  2. MrMuzyk commented on Apr 15, 2026

    @MrMuzyk
    Contributor

    I am Michał from Callstack - expert contributor group. I’d like to work on this job.

  3. MrMuzyk commented on Apr 17, 2026

    @MrMuzyk
    Contributor

    Will take a while to release this, bump is now 3.0.61 and this changes are in 3.0.68

  4. MrMuzyk commented on Apr 29, 2026

    @MrMuzyk
    Contributor

    Preparing Bump PR

  5. MrMuzyk commented on May 7, 2026

    @MrMuzyk
    Contributor

    Bump on staging

  6. added and removed
    ReviewingHas a PR in review
    on May 8, 2026
  7. changed the title [-]Improve retryOperation and reportStorageQuota logging to include original error[/-] [+][Due for payment 2026-05-15] Improve retryOperation and reportStorageQuota logging to include original error[/+] on May 8, 2026
  8. melvin-bot commented on May 8, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on May 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-15. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on May 11, 2026

    @melvin-bot

    @fabioh8010 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. changed the title [-][Due for payment 2026-05-15] Improve retryOperation and reportStorageQuota logging to include original error[/-] [+]Improve retryOperation and reportStorageQuota logging to include original error[/+] on May 12, 2026
  12. Julesssss commented on May 12, 2026

    @Julesssss
    ContributorAuthor

    Payment handled in the sibling issue: #74470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions