[$250] Expense preview - Disabled list report field value is displayed on expense preview

@Pujan92

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.21-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57923
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Money Requests

Action Performed:

Enable report fields
Go to Report fields > Add field > Add name > select list type > Add list values > select initial value
Go offline > Click Save
Go to the workspace chat
Create expense
Return to the workspace Report field
Select the list report field > List values > disable all added values
Return to the workspace chat > open the expense
Apply online mode

Expected Result:

Report field on the expense preview shouldn't be displayed

Actual Result:

Report field on the expense preview shows the report fields initial value

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6784750_1743110346795.Dvnb8264_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021906953766885392501
Upwork Job ID: 1906953766885392501
Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @Pujan92

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report field on the expense preview shows the report fields initial value

What is the root cause of that problem?

We only hide the report field if the fieldValue is not empty. In our case reportField.defaultValue is not empty then this returns false.

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 100 to 104 in 045a3ba

    
           const shouldHideSingleReportField = (reportField: PolicyReportField) => { 
        
               const fieldValue = reportField.value ?? reportField.defaultValue; 
        
               const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST || reportField.disabledOptions.some((option) => !option); 
        
               return isReportFieldOfTypeTitle(reportField) || (!fieldValue && !hasEnableOption);

What changes do you think we should make in order to solve the problem?

I think we can remove !fieldValue check here

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 100 to 104 in 045a3ba

    
           const shouldHideSingleReportField = (reportField: PolicyReportField) => { 
        
               const fieldValue = reportField.value ?? reportField.defaultValue; 
        
               const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST || reportField.disabledOptions.some((option) => !option); 
        
               return isReportFieldOfTypeTitle(reportField) || (!fieldValue && !hasEnableOption);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@nkdengineer

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense preview - Disabled list report field value is displayed on expense preview

What is the root cause of that problem?

We won't hide the field if we the list report field has a defaultValue

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 100 to 104 in 045a3ba

    
           const shouldHideSingleReportField = (reportField: PolicyReportField) => { 
        
               const fieldValue = reportField.value ?? reportField.defaultValue; 
        
               const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST || reportField.disabledOptions.some((option) => !option); 
        
               return isReportFieldOfTypeTitle(reportField) || (!fieldValue && !hasEnableOption);

What changes do you think we should make in order to solve the problem?

We need to only avoid hiding the field only if it has a previously set value (defaultValue shouldn't matter) so we should remove the reportField.defaultValue from here

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 101 in 045a3ba

const fieldValue = reportField.value ?? reportField.defaultValue;

This is exactly the logic we use for other list fields like category in other places as here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 218 in 1c74508

    
           const shouldShowCategory = isPolicyExpenseChat && (transactionCategory || hasEnabledOptions(policyCategories ?? {}));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not needed

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021906953766885392501

@Pujan92

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@Pujan92

@Pujan92 12 days overdue now... This issue's end is nigh!

@kadiealexander

@kadiealexander Let's close this issue based on #59355 (comment)

@Pujan92

@Pujan92 @kadiealexander this issue is now 4 weeks old, please consider:

Finding a contributor to fix the bug
Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@Pujan92

@Pujan92 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Pujan92

@Pujan92 Huh... This is 4 days overdue. Who can take care of this?

@Pujan92

@Pujan92 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@Pujan92

@Pujan92 10 days overdue. I'm getting more depressed than Marvin.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Pujan92

@Pujan92 12 days overdue. Walking. Toward. The. Light...

Navigation Menu

Repository navigation

[$250] Expense preview - Disabled list report field value is displayed on expense preview #59355

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const shouldHideSingleReportField = (reportField: PolicyReportField) => {
	const fieldValue = reportField.value ?? reportField.defaultValue;
	const hasEnableOption = reportField.type !== CONST.REPORT_FIELD_TYPES.LIST \|\| reportField.disabledOptions.some((option) => !option);

	return isReportFieldOfTypeTitle(reportField) \|\| (!fieldValue && !hasEnableOption);

[$250] Expense preview - Disabled list report field value is displayed on expense preview #59355

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 31, 2025

nkdengineer commented on Mar 31, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

github-actions commented on Mar 31, 2025

FitseTLT commented on Mar 31, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Apr 1, 2025

melvin-bot commented on Apr 1, 2025

16 remaining items

melvin-bot commented on Apr 23, 2025

Pujan92 commented on Apr 24, 2025

melvin-bot commented on Apr 28, 2025

melvin-bot commented on Apr 28, 2025

melvin-bot commented on Apr 29, 2025

melvin-bot commented on Apr 30, 2025

melvin-bot commented on May 2, 2025

melvin-bot commented on May 6, 2025

melvin-bot commented on May 6, 2025

melvin-bot commented on May 8, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions