Repository navigation
Deploy Checklist: New Expensify 2024-06-13 #43655
Description
Release Version: 1.4.83-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Switch NavLink to Link (mobile can't use NavLink) #21
- Add focus trap #39520
- Animate sign-in pages #40337
- fix User has to click twice to select currency #42380
- Fix: add spacing between comment and Uploading attachment... #42516
- Refactor/36648 wallet enablement flow connect steps #42589
- Enable
no-unsafe-calleslint rule #42743 - Bump onyx to 2.0.48 (after revert) #42772
- Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819
- show onboarding modal for RHP signin from public rooms for new accounts #42820
- Fix: can't open tag with tag name with % characters #42937
- [No QA][HelpDot] Enforce adding of a redirect if an article is rename/moved/deleted. #42954
- Add a switch for requiring tags on the multi level tags RHP #42972
- fix: Taxes - Edited tax is not grayed out in Tax list in submit manual flow. #42974
- show card when it's a card transaction #42999
- Incorrect video is paused after turning on and off full screen mode #43025
- [Payment card / Subscription] Implement changing plan actions #43029
- Fix Slow Chat Switcher issue #43099
- fix: update regex to remove redundant slash #43157
- Keep "Only visible to" tag on all whispers even if there are pending actions #43198
- prevent system messages in transaction level from appearing as last message text in LHN in selfDM #43254
- Set optimistic policy creation with "Instant submit" #43273
- [No QA] Prefer type-fest (custom ESLint rule) #43301
- [ideal nav] Exclude abracadabra page from saving in the last visited path #43303
- Revert using timestamps for created when submitting money requests #43319
- Update en.ts #43439
- Fix long pressing the comment reaction does not open the reactions modal the first time you do it #43464
- Update Connect-a-Business-Bank-Account.md #43480
- Memoize for BottomTabBar #43495
- [No QA][TS Migration] Follow up - Add comments for remaining properties in Onyx types #43499
- Remove unused
DISMMISSED_REASONconst #43504 - Use gh cli for production deploy #43516
- Add successData to the completeGuidedSetup #43568
- Fix react-pdf patch-package soft warning #43601
- [CP Staging] fix modal views are not fully shown #43706
- [CP Staging] Disable initial focus in modals #43743
- [CP Staging] Fix autofocus on Sign In page #43752
Deploy Blockers:
- [Awaiting checklist] [$250] IOU - App crashed after deleting IOU and relaunching app #42529
- [HOLD for payment 2024-06-20] Track - "Hold" appears for tracked expense on right-click menu, but not in transaction thread #43589
- [HOLD for payment 2024-06-24] [$250] The FAB or Search category selector are narrow #43657
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - First menu item in the composer is highlighted #43659
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Attachment - Attachment preview does not show the image #43660
- [HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP #43662
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mweb - Login - Sign in page scroll to bottom when sign in from public room #43664
- [HOLD for payment 2024-07-24] [$250] QBO - "Required" remains enabled when all tags are disabled #43666
- [$250] Web - Expense - Two RHPs open when opening Add receipt modal via TAB key #43679
- [$250] Pay someone - Console error shows up when changing payment #43691
- [$250] mWeb - Chat - Emoji picker cut off in the bottom #43692
- Wallet - Wallet cannot be enabled after Onfido identify #43709
- [HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login #43713
- [$250] Chat - cursor isn't moved to the end of the pasted text while context menu is open #43717
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] mWeb - Login – Animation appears with delay when navigate via magic link in incognino tab #43718
- [HOLD for Payment 2024-08-22] [$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB #43719
- [HOLD for payment 2024-07-10] [$250] Concierge - User is not landed on Concierge chat via deeplink #43727
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Categories - Categories header jumps when clicking Select after selecting categories #43736
- [$250] iOS - Bank account - Error appears when going back to choose an account and try to continue #43753
- [HOLD for payment 2024-07-24] [$250] QBO - Tag status does not change when "Members must tag all expenses" is updated offline #43754
- [HOLD for payment 2024-06-28] Multi tags - Error shows up when disabling "Required" toggle #43758
- [Payment due now][$250] Send Invoice - Workspace Display Name Not Shown in Invoice Preview #43759
- [$250] Workspace - "Incorporation state" closes and field validation error occurs while adding a BA #43761
- [HOLD for payment 2024-07-10] Composer is not highlighted when focused after enabling toggle and clicking + button #43766
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jun 13, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.83-0 🚀
tgolen commentedon Jun 13, 2024
Demoting #43719 because it's an extreme edge case
luacmartins commentedon Jun 13, 2024
Demoted #43659
luacmartins commentedon Jun 13, 2024
Demoted #43713
srikarparsi commentedon Jun 13, 2024
Demoted #43718
luacmartins commentedon Jun 13, 2024
Removed the label on Wallet - Wallet cannot be enabled after Onfido identify , not a client issue.
rlinoz commentedon Jun 13, 2024
Demoting #43691 since it is a backend issue.
kavimuru commentedon Jun 14, 2024
Regression is 59% progress.
unchecked PRs:
#40337 desktop validation blocked with #34585 (comment)
#42589 - failing with #43709
#42820 failing with existing issue and commented #42820 (comment)
#42972 failing with #43666
#42974 failing with the existing issue and commented #42974 (comment)
#43029 failing with #43555 and repro in production. Checking it off
mountiny commentedon Jun 14, 2024
demoted #43766
carlosmiceli commentedon Jun 14, 2024
Closed #43759, can't reproduce in either staging or prod.
rlinoz commentedon Jun 14, 2024
Demoted #43758
kavimuru commentedon Jun 14, 2024
Regression completed.
Regression is 59% progress.
unchecked PRs:
#40337 desktop validation blocked with #34585 (comment)
#42589 - failing with #43709
#42820 failing with existing issue and commented #42820 (comment)
#42972 failing with #43666
Open blockers:
#43717
#43736
#43753
#43761
carlosmiceli commentedon Jun 14, 2024
Removing deploy blocker label from #43717 because it's such an edge case and we haven't found a solution yet, but will keep as daily bug until solved.
mountiny commentedon Jun 14, 2024
All of these are not blockers, either already handled or failing the original problem
All blockers are cleared, waiting for one validation
mountiny commentedon Jun 14, 2024
Created this one crash issue #43790
mountiny commentedon Jun 14, 2024
Everything is cleared now!
mountiny commentedon Jun 14, 2024