Repository navigation
Deploy Checklist: New Expensify 2024-05-27 #42636
Copy link
Copy link
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.76-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- fix: Fix scrollable elements in Policy pages. #38719
- Handle tax for split requests #40240
- fix android com.facebook.jni.CppException crash #40872
- Remove report screen logs #41220
- Add error for failure invited member v2 #41479
- Bump expensify-common & react-native-live-markdown to fix phone number mentions #41666
- Add markAsCash button with wired up action for dismissing the rter violation #41835
- [Snyk] Security upgrade react-pdf from 7.7.1 to 7.7.3 #41869
- Fix can't navigate with arrow key to admin in group members page #41968
- [Travel] [Refactor] Create a new shared component for AddressPage #41970
- DOCS: Create Deactivate-or-cancel-an-Expensify-Card.md #41995
- DOCS: Create Change-Expensify-Card-limit.md #41996
- Update LHN to display transaction level actions for one-transaction reports #42005
- Merchant name of the deleted expense in OD report is still shown in ND report #42015
- Fix scan tax error #42024
- Add deferred updates queue functions to
OnyxUpdateManagerto manually apply updates (e.g. from push notifications) #42044 - Fullstory integration Update. #42046
- Bump Onyx to 2.0.41 #42057
- Wrap the merchant text in the transaction field view #42131
- Navigate back to the last accessed report when leaving a thread #42132
- Android anchor markdown format 40564 #42147
- Playing video is not paused when opening attachment modal. #40735 #42157
- Delete docs/articles/expensify-classic/expenses/Referral-Program.md #42198
- Don't hide empty group chats #42234
- Fix expense preview with multiline description shows two spacings between each line in search page #42243
- Replace the "MERGED_" prefix correctly #42260
- fix: empty cell being shown when submitting and opening an expense in offline mode #42276
- Fix text attachment edit comment bug #42290
- Update CONTRIBUTING.md #42327
- Fix pdf blinks when open it #42333
- Fix chat header appears after delay when opening expense/transaction report #42334
- remove offline indicator on wide screen #42349
- Fix width of text input in split expense page #42362
- [No QA] Enable
no-unsafe-argumenteslint rule #42391 - Fix linked message visibility in offline mode #42396
- Fix crash when selectin the bank account picker placeholder item #42404
- fix: Clicking on a very long parent child category #42405
- Update onboarding message #42408
- Include more segment info #42416
- DOCS: Create Approve-and-pay-expenses.md #42418
- DOCS: Create Set-up-Xero-connection.md #42422
- Make header buttons flexible (grow and shrink) to take full available space #42443
- Fix “Assign to me” missing in list of assignees #42474
- Update en.ts #42493
- Correctly find Worspace Expense chats when inviting users #42500
- Fix no error message appears when trying to create an impossible route #42501
- Revert "Fix linked message visibility in offline mode" #42612
- Fix linked message visibility in offline mode #42628
- [No QA] Using OnyxEntry instead of explicit type #42646
- Revert "Handle tax for split requests" #42670
- [CP Staging] Revert "[Travel] [Refactor] Create a new shared component for AddressPage" #42697
- Fix header in Home page is missing briefly when app is launched #42702
- Bump iOS deployment target to 15 #42707
- [CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-… #42725
Internal QA:
Deploy Blockers:
- [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Profile - Unable to select a different country when there is existing address #42638
- [Awaiting checklist completion] [$250] IOS - Launch app - Header in Home page is missing briefly when app is launched #42639
- Tax - Split scan - Selected tax rate is duplicated in Tax rate list #42642
- Tax - Split scan - Unable to save tax amount when the tax amount does not exceed limit #42649
- Tax - Tax rate and amount are blank when tax rate is selected when splitting expense #42652
- Onboarding - Some copy is not removed #42653
- [$250] App performance - Laggy transition when switching from one report to another #42654
- Expense - Unable to select a different currency in transaction thread #42655
- [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] iOS- Launch - App crashes at launch on IOS 14 #42656
- Profile - Address - State/Province field remains blank after entering address #42681
- Tax - Tax amount is not updated when changing Tax rate #42682
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon May 27, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.76-0 🚀
blimpich commentedon May 27, 2024
Demoting #42642
kavimuru commentedon May 27, 2024
Regression is 67% progress.
#41970 failing with #42638
#42234 failing with #40314 not fixed in mweb and android #42234 (comment)
We still have the PRs to be validated.
bondydaa commentedon May 27, 2024
we reverted a PR (#40240) and CP'd (#42670) it to staging b/c we believe it caused the following blockers, @kavimuru could you have the testers re-test these and close out them out if they're not reproducible?
#42655
#42652
#42649
#42643
#42642
I'll also bump those GHs
bondydaa commentedon May 27, 2024
i also checked off #40240 from the list as well
kavimuru commentedon May 28, 2024
#42643 is reproducible and these following bugs are blocked. Waiting for the original bug reported to reproduce this issue.
42643.mp4
#42652
#42649
#42642
roryabraham commentedon May 28, 2024
Checked off #42447 as a QA pass
kavimuru commentedon May 28, 2024
Regression is 14% left
Unchecked PRs:
#41970 failing with #42638
#42234 failing with #40314 not fixed in mweb and android #42234 (comment)
#40240 - Pending validation in mweb, desktop and android
#41835 - Pending validation in web and desktop
#42005 - Pending validation in desktop android and iOS
#42015 Pending validation in desktop android and iOS
#42243 Pending validation in all the platforms
#42260 - Pending validation in ios,mweb, desktop and android
#42334 - Pending validation in desktop android and iOS
#42408 Pending validation in mweb android and iOS
#42046 - Pending validation in all the platforms
kavimuru commentedon May 28, 2024
Regression is completed
Unchecked PRs:
#40240 - PR reverted - checking it off
#41970 failing with #42638
#42005 - failing with #39450 not fixed in mweb
#42408 failing with #42653
#42234 failing with #40314 not fixed in mweb and android #42234 (comment)
Open Blockers:
#42638
#42639
#42653
#42654
#42656
#42681
puneetlath commentedon May 28, 2024
@kavimuru can we re-test #42638. It should be fixed by #42697.
Julesssss commentedon May 28, 2024
#42707 should be fixed with the next update
Beamanator commentedon May 29, 2024
#42654 fixed by #42725, checking both off & running final few checks before we ship!
Beamanator commentedon May 29, 2024