Repository navigation
perf(editor): decouple viewport frame readback - #367
Open
Excurs1ons wants to merge 1 commit into
Open
Excurs1ons wants to merge 1 commit into
Excurs1ons wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
缺少 |
github-actions
Bot
added
area/engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Agent: OpenCode (GPT-6.1 Sol)
Why
SceneView/GameView suffered from synchronous GPU readback and frame delivery on the viewport thread. This change removes the blocking readback wait and prevents slow IPC/canvas consumers from building a stale frame queue.
Changes
Verify
pnpm build(editor): passed.cargo fmt --allandgit diff --check: passed.python3 scripts/pr_ready.py --quick: formatting/artifact checks passed; clippy could not run because generatedassets/shaders/*.spvfiles are absent in this environment.Runtime FPS validation on a Vulkan desktop is still required.