Repository navigation
fix(asset): add handle pin API to protect live assets from eviction - #365
Merged
Merged
Conversation
Introduce pin/unpin/is_pinned API on ResourceManager to prevent automatic eviction from discarding assets referenced by active callers while keeping Handle<T>: Copy. Fixes #172
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Antigravity (Google DeepMind)
Summary
Add an explicit pin/unpin/is_pinned API to
ResourceManager(Option A from #172) while preservingHandle<T>: Copy. Automatic memory budget eviction (LRU and FIFO) filters out pinned slots from eviction candidates, preventing live handles from being discarded and failing withNotLoaded.pin_count: u32to internalSlot.ResourceManager::evict, filter candidates to only slots wherepin_count == 0.pin,unpin,is_pinned,pin_countfor typedHandle<T>, type-erasedAnyHandle, andAssetId.RuntimeError::PinUnderflowifunpinis called with count 0.unload,unload_id, andunload_allresetpin_countto 0.runtime::testscovering eviction skipping pinned slots, out-of-memory when all candidate assets are pinned, eviction succeeding once unpinned, generation mismatch checks, and unload resets.Fixes #172
Self-check (
scripts/pr_ready.py)origin/master· HEAD:6880a5f· changed: 2 file(s)prism-assetResult: ✅ all checks passed