Process completed crawl pages during the crawl - #492
Open
PrzemyslawKlys wants to merge 3 commits into
Open
PrzemyslawKlys wants to merge 3 commits into
PrzemyslawKlys wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## perf/crawl-streamed-chunks #492 +/- ##
==============================================================
+ Coverage 58.19% 58.54% +0.35%
==============================================================
Files 488 488
Lines 36107 36117 +10
Branches 7284 7286 +2
==============================================================
+ Hits 21013 21146 +133
+ Misses 12728 12576 -152
- Partials 2366 2395 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PrzemyslawKlys
force-pushed
the
feature/crawl-page-observer
branch
from
October 5, 2026 22:56
d92ec41 to
0491367
Compare
PrzemyslawKlys
changed the base branch from
v2-speedygonzales
to
perf/crawl-streamed-chunks
October 5, 2026 22:56
PrzemyslawKlys
added this pull request to stack #504
October 5, 2026 22:59
PrzemyslawKlys
force-pushed
the
feature/crawl-page-observer
branch
from
October 6, 2026 04:00
0491367 to
0668a14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crawl consumers process extracted pages as they arrive through
HtmlCrawlOptions.PageObserverandIHtmlCrawlPageObserver. The crawler awaits the callback after extraction and optional asset downloads, before committing the page's checkpoint. It delivers successful and failed result pages in crawl order; skipped candidates and checkpoint-loaded pages are excluded.Invoke-HtmlCrawl -StreamPagessends these pages to the PowerShell pipeline instead of returning the final crawl result. Default output stays the same. Callback failures and cancellation propagate, and external sinks should tolerate a retry of an uncommitted callback. Pipeline output acknowledges queueing rather than completion of downstream processing; export files may be committed after a page is emitted.This layer builds on streamed chunk export #497. Content release #501 uses the observer to keep streamed copies available while releasing the crawl's retained bodies. The stack order is #497, #492, then #501.
Validation: the rebased layer passes 10 related observer, runspace and structure checks on .NET 10 and .NET 8, and eight on .NET Framework 4.7.2. Both public pipeline cases pass in PowerShell 5.1 and 7, including a response held until the first page reaches the pipeline. The standalone callback contract has an independent source review; the subsequent content-release interaction was also reviewed. Current CI remains a merge gate.