fix: PR-8 - canonical Phorest booking URL, data-driven CTAs - #8
Merged
Merged
Conversation
Mark's correction from the live site: the real booking link is https://www.phorest.com/salon/mintontheavenue — the request-appointment page is being phased out. - seed: bookingUrl confirmed (closes the TO_CONFIRM item), provenance note records who confirmed and when - pages.ts: the hardcoded booking URL dies — ctaRow reads entity.bookingUrl (https-validated); a salon without one simply gets no book button, call/text remain. The generic-platform way. - live suite asserts the CTA targets the canonical Phorest URL, encoded through /go tracking The correction is itself provenance: the changed seed file yields a new content-addressed run id; the salon doc's next version chains to it. TRACE shows the booking URL changed, when, and on whose word. Verified: tsc clean · unit 30/30 · live 4/4 vs nedbd 2.6.1 · build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live-site correction from Mark: the canonical booking link is
https://www.phorest.com/salon/mintontheavenue(request-appointment is being phased out). The seed gets the confirmed URL; the hardcoded fallback inctaRowis deleted — booking CTAs are now data-driven fromentity.bookingUrl.Why this matters
Booking is THE conversion path. And the fix removes the last hardcoded salon fact from the render plane — every CTA now reads the engine, which is what "configuration determines behavior" means at the button level.
Tests run (locally, real engine)
tscclean · unit 30/30 · live 4/4 — new assertion: the home CTA carries the encoded canonical Phorest URL through/go/booking_click.Deploy note
After merge:
git pull && pnpm run build && npm run seed && restart. The seed run will WRITE this time (file content changed → new run idrun_…→ salon doc updates, history preserved). Expect a non-zero writes count and✓ verify ok.